Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Unified Diff: third_party/WebKit/Source/web/WebPagePopupImpl.h

Issue 2290313002: Remove PlatformKeyboardEvent (Closed)
Patch Set: One more fix Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebPagePopupImpl.h
diff --git a/third_party/WebKit/Source/web/WebPagePopupImpl.h b/third_party/WebKit/Source/web/WebPagePopupImpl.h
index 8f953e4dfc7fbc7141807e0630ee7827d835bc7d..06d9127e5e8e93ae1f9d724d823ab7b95dd89bc4 100644
--- a/third_party/WebKit/Source/web/WebPagePopupImpl.h
+++ b/third_party/WebKit/Source/web/WebPagePopupImpl.h
@@ -42,7 +42,6 @@ class GraphicsLayer;
class Page;
class PagePopupChromeClient;
class PagePopupClient;
-class PlatformKeyboardEvent;
class WebLayerTreeView;
class WebLayer;
class WebViewImpl;
@@ -59,7 +58,6 @@ class WebPagePopupImpl final
public:
~WebPagePopupImpl() override;
bool initialize(WebViewImpl*, PagePopupClient*);
- WebInputEventResult handleKeyEvent(const PlatformKeyboardEvent&);
void closePopup();
WebWidgetClient* widgetClient() const { return m_widgetClient; }
bool hasSamePopupClient(WebPagePopupImpl* other) { return other && m_popupClient == other->m_popupClient; }
@@ -70,6 +68,9 @@ public:
void postMessage(const String& message) override;
void cancel();
+ // PageWidgetEventHandler functions.
+ WebInputEventResult handleKeyEvent(const WebKeyboardEvent&) override;
+
private:
// WebWidget functions
void beginFrame(double lastFrameTimeMonotonic) override;
@@ -84,7 +85,6 @@ private:
bool isAcceleratedCompositingActive() const override { return m_isAcceleratedCompositingActive; }
// PageWidgetEventHandler functions
- WebInputEventResult handleKeyEvent(const WebKeyboardEvent&) override;
WebInputEventResult handleCharEvent(const WebKeyboardEvent&) override;
WebInputEventResult handleGestureEvent(const WebGestureEvent&) override;
void handleMouseDown(LocalFrame& mainFrame, const WebMouseEvent&) override;

Powered by Google App Engine
This is Rietveld 408576698