Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2288563002:
Treat implicit height on positioned objects as non-auto (Closed)
|
Created:
4 years, 3 months ago by rhogan Modified:
4 years, 3 months ago CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1 Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionTreat implicit height on positioned objects as non-auto
When calculating a block's percentage relativePositionOffset() we ought to consider
containing blocks with an implicit height from top/bottom as having a height we
can use to calculate an offset from.
BUG=61049
Committed: https://crrev.com/58c72c8f8fee69a33265fa7552ec3522383930f1
Cr-Commit-Position: refs/heads/master@{#415415}
Patch Set 1 #
Total comments: 1
Patch Set 2 : bug 61049 #
Total comments: 4
Patch Set 3 : bug 61049 #Patch Set 4 : bug 61049 #
Messages
Total messages: 34 (22 generated)
The CQ bit was checked by robhogan@gmail.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Treat implicit height on positioned objects as non-auto BUG=61049 ========== to ========== Treat implicit height on positioned objects as non-auto When calculating a block's percentage relativePositionOffset() we ought to consider containing blocks with an implicit height from top/bottom as having a height we can use to calculate an offset from. BUG=61049 ==========
robhogan@gmail.com changed reviewers: + eae@chromium.org
mstensho@opera.com changed reviewers: + mstensho@opera.com
https://codereview.chromium.org/2288563002/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp (right): https://codereview.chromium.org/2288563002/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp:547: if (logicalHeightLength.isAuto() && !isOutOfFlowPositionedWithImplicitHeight) How about not evaluating "isOutOfFlowPositioned() && !style()->logicalTop().isAuto() && !style()->logicalBottom().isAuto()" before we have checked that height is auto?
The CQ bit was checked by robhogan@gmail.com to run a CQ dry run
On 2016/08/29 at 13:51:02, mstensho wrote: > https://codereview.chromium.org/2288563002/diff/1/third_party/WebKit/Source/c... > File third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp (right): > > https://codereview.chromium.org/2288563002/diff/1/third_party/WebKit/Source/c... > third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp:547: if (logicalHeightLength.isAuto() && !isOutOfFlowPositionedWithImplicitHeight) > How about not evaluating "isOutOfFlowPositioned() && !style()->logicalTop().isAuto() && !style()->logicalBottom().isAuto()" before we have checked that height is auto? Done!
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
https://codereview.chromium.org/2288563002/diff/20001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/fast/block/positioning/relative-with-implicit-height-containing-block-2.html (right): https://codereview.chromium.org/2288563002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/fast/block/positioning/relative-with-implicit-height-containing-block-2.html:30: <div id="child" data-positioned-offset-y=300></div> I don't like that we make assumptions about the window height here. https://codereview.chromium.org/2288563002/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp (right): https://codereview.chromium.org/2288563002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp:495: static bool isOutOfFlowPositionedWithImplicitHeight(LayoutBlock* child) static inline and const LayoutBlock?
LGTM once mortens concerns have been addressed
https://codereview.chromium.org/2288563002/diff/20001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/fast/block/positioning/relative-with-implicit-height-containing-block-2.html (right): https://codereview.chromium.org/2288563002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/fast/block/positioning/relative-with-implicit-height-containing-block-2.html:30: <div id="child" data-positioned-offset-y=300></div> On 2016/08/29 at 16:02:26, mstensho wrote: > I don't like that we make assumptions about the window height here. It's about testing a container tree that is auto all the way up, so I think I'm forced to right?
The CQ bit was checked by robhogan@gmail.com to run a CQ dry run
https://codereview.chromium.org/2288563002/diff/20001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/fast/block/positioning/relative-with-implicit-height-containing-block-2.html (right): https://codereview.chromium.org/2288563002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/fast/block/positioning/relative-with-implicit-height-containing-block-2.html:30: <div id="child" data-positioned-offset-y=300></div> On 2016/08/29 20:36:01, rhogan wrote: > On 2016/08/29 at 16:02:26, mstensho wrote: > > I don't like that we make assumptions about the window height here. > > It's about testing a container tree that is auto all the way up, so I think I'm > forced to right? I realize that you want to do that, since the rest is covered by the other test. If you want to hard-code the expected offset, you could put all of this inside an iframe with fixed height. Or, you could use testharness with an assert_equals(child.getClientRects[0].top, window.innerHeight / 2) or something like that.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by robhogan@gmail.com to run a CQ dry run
On 2016/08/29 at 21:04:38, mstensho wrote: > Or, you could use testharness with an assert_equals(child.getClientRects[0].top, window.innerHeight / 2) or something like that. Oh nice, I wouldn't have thought of that - done.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by robhogan@gmail.com
The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org Link to the patchset: https://codereview.chromium.org/2288563002/#ps60001 (title: "bug 61049")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Treat implicit height on positioned objects as non-auto When calculating a block's percentage relativePositionOffset() we ought to consider containing blocks with an implicit height from top/bottom as having a height we can use to calculate an offset from. BUG=61049 ========== to ========== Treat implicit height on positioned objects as non-auto When calculating a block's percentage relativePositionOffset() we ought to consider containing blocks with an implicit height from top/bottom as having a height we can use to calculate an offset from. BUG=61049 Committed: https://crrev.com/58c72c8f8fee69a33265fa7552ec3522383930f1 Cr-Commit-Position: refs/heads/master@{#415415} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/58c72c8f8fee69a33265fa7552ec3522383930f1 Cr-Commit-Position: refs/heads/master@{#415415} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
