third_party/WebKit/LayoutTests/fast/block/positioning/relative-with-implicit-height-containing-block-2.html - Issue 2288563002: Treat implicit height on positioned objects as non-auto

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/block/positioning/relative-with-implicit-height-containing-block-2.html

Issue 2288563002: Treat implicit height on positioned objects as non-auto (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: bug 61049 Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/block/positioning/relative-with-implicit-height-containing-block.html ('k') | third_party/WebKit/LayoutTests/fast/block/positioning/relative-with-implicit-height-containing-block-2-expected.txt » ('j') | third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style>

	3 #wrapper {

	4 position: absolute;

	5 top: 0px;

	6 left: 0px;

	7 bottom: 0px;

	8 right: 0px;

	9 }

	10 #child {

	11 position: relative;

	12 width: 100px;

	13 height: 100px;

	14 top: 50%;

	15 background-color: green;

	16 }

	17 #ref {

	18 position: absolute;

	19 width: 100px;

	20 height: 100px;

	21 top: 300px;

	22 left: 0px;

	23 background-color: red;

	24 }

	25 </style>

	26 <p>crbug.com/61049: There should be no red box below.</p>

	27 <div id="log"></div>

	28 <div id="ref"></div>

	29 <div id="wrapper">

	30 <div id="child" data-positioned-offset-y=300></div>
	mstensho (USE GERRIT) 2016/08/29 16:02:26 I don't like that we make assumptions about the wi I don't like that we make assumptions about the window height here. rhogan 2016/08/29 20:36:01 It's about testing a container tree that is auto a Show quoted text On 2016/08/29 at 16:02:26, mstensho wrote: > I don't like that we make assumptions about the window height here. It's about testing a container tree that is auto all the way up, so I think I'm forced to right? mstensho (USE GERRIT) 2016/08/29 21:04:38 I realize that you want to do that, since the rest Show quoted text On 2016/08/29 20:36:01, rhogan wrote: > On 2016/08/29 at 16:02:26, mstensho wrote: > > I don't like that we make assumptions about the window height here. > > It's about testing a container tree that is auto all the way up, so I think I'm > forced to right? I realize that you want to do that, since the rest is covered by the other test. If you want to hard-code the expected offset, you could put all of this inside an iframe with fixed height. Or, you could use testharness with an assert_equals(child.getClientRects[0].top, window.innerHeight / 2) or something like that.
	31 </div>

	32 <script src="../../../resources/check-layout.js"></script>

	33 <script>

	34 checkLayout("#child", log);

	35 </script>

OLD	NEW