Chromium Code Reviews Chromium Code Reviews
Issue 2288563002:
Treat implicit height on positioned objects as non-auto (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW |
|---|---|
| 1 /* | 1 /* |
| 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) | 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) |
| 3 * (C) 1999 Antti Koivisto (koivisto@kde.org) | 3 * (C) 1999 Antti Koivisto (koivisto@kde.org) |
| 4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) | 4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) |
| 5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com) | 5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com) |
| 6 * Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. | 6 * Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. |
| 7 * Copyright (C) 2010 Google Inc. All rights reserved. | 7 * Copyright (C) 2010 Google Inc. All rights reserved. |
| 8 * | 8 * |
| 9 * This library is free software; you can redistribute it and/or | 9 * This library is free software; you can redistribute it and/or |
| 10 * modify it under the terms of the GNU Library General Public | 10 * modify it under the terms of the GNU Library General Public |
| (...skipping 525 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 536 LayoutFlexibleBox& flexBox = toLayoutFlexibleBox(*parent()); | 536 LayoutFlexibleBox& flexBox = toLayoutFlexibleBox(*parent()); |
| 537 if (flexBox.childLogicalHeightForPercentageResolution(*thisBox) != Layou tUnit(-1)) | 537 if (flexBox.childLogicalHeightForPercentageResolution(*thisBox) != Layou tUnit(-1)) |
| 538 return false; | 538 return false; |
| 539 } | 539 } |
| 540 if (thisBox && thisBox->isGridItem()) { | 540 if (thisBox && thisBox->isGridItem()) { |
| 541 if (checkingContainingBlock && thisBox->hasOverrideLogicalContentHeight( )) | 541 if (checkingContainingBlock && thisBox->hasOverrideLogicalContentHeight( )) |
| 542 return false; | 542 return false; |
| 543 if (!checkingContainingBlock && thisBox->hasOverrideContainingBlockLogic alHeight()) | 543 if (!checkingContainingBlock && thisBox->hasOverrideContainingBlockLogic alHeight()) |
| 544 return false; | 544 return false; |
| 545 } | 545 } |
| 546 if (logicalHeightLength.isAuto()) | 546 bool isOutOfFlowPositionedWithImplicitHeight = isOutOfFlowPositioned() && !s tyle()->logicalTop().isAuto() && !style()->logicalBottom().isAuto(); |
| 547 if (logicalHeightLength.isAuto() && !isOutOfFlowPositionedWithImplicitHeight ) | |
|
mstensho (USE GERRIT)
2016/08/29 13:51:02
How about not evaluating "isOutOfFlowPositioned()
| |
| 547 return true; | 548 return true; |
| 548 | 549 |
| 549 if (document().inQuirksMode()) | 550 if (document().inQuirksMode()) |
| 550 return false; | 551 return false; |
| 551 | 552 |
| 552 // If the height of the containing block computes to 'auto', then it hasn't been 'specified explicitly'. | 553 // If the height of the containing block computes to 'auto', then it hasn't been 'specified explicitly'. |
| 553 if (cb) | 554 if (cb) |
| 554 return cb->hasAutoHeightOrContainingBlockWithAutoHeight(true); | 555 return cb->hasAutoHeightOrContainingBlockWithAutoHeight(true); |
| 555 return false; | 556 return false; |
| 556 } | 557 } |
| (...skipping 548 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 1105 if (rootElementStyle->hasBackground()) | 1106 if (rootElementStyle->hasBackground()) |
| 1106 return false; | 1107 return false; |
| 1107 | 1108 |
| 1108 if (node() != document().firstBodyElement()) | 1109 if (node() != document().firstBodyElement()) |
| 1109 return false; | 1110 return false; |
| 1110 | 1111 |
| 1111 return true; | 1112 return true; |
| 1112 } | 1113 } |
| 1113 | 1114 |
| 1114 } // namespace blink | 1115 } // namespace blink |
| OLD | NEW |
