chrome/browser/extensions/extension_sorting_unittest.cc - Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_sorting_unittest.cc

Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Removed C-style casts. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_sorting.cc ('k') | chrome/browser/extensions/extension_special_storage_policy_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_sorting_unittest.cc

diff --git a/chrome/browser/extensions/extension_sorting_unittest.cc b/chrome/browser/extensions/extension_sorting_unittest.cc

index b84535ee4936540c4c201934deb11a9a810c55a2..6a51402f9c0bc1dd21b45d5e144d60d2a2a2b4fb 100644

--- a/chrome/browser/extensions/extension_sorting_unittest.cc

+++ b/chrome/browser/extensions/extension_sorting_unittest.cc

@@ -165,24 +165,24 @@ class ExtensionSortingInitialize

static_cast<ExtensionScopedPrefs*>(prefs());

scoped_prefs->UpdateExtensionPref(extension1()->id(),

kPrefAppLaunchIndexDeprecated,

- Value::CreateIntegerValue(0));

+ new base::FundamentalValue(0));

scoped_prefs->UpdateExtensionPref(extension1()->id(),

kPrefPageIndexDeprecated,

- Value::CreateIntegerValue(0));

+ new base::FundamentalValue(0));

scoped_prefs->UpdateExtensionPref(extension2()->id(),

kPrefAppLaunchIndexDeprecated,

- Value::CreateIntegerValue(1));

+ new base::FundamentalValue(1));

scoped_prefs->UpdateExtensionPref(extension2()->id(),

kPrefPageIndexDeprecated,

- Value::CreateIntegerValue(0));

+ new base::FundamentalValue(0));

scoped_prefs->UpdateExtensionPref(extension3()->id(),

kPrefAppLaunchIndexDeprecated,

- Value::CreateIntegerValue(0));

+ new base::FundamentalValue(0));

scoped_prefs->UpdateExtensionPref(extension3()->id(),

kPrefPageIndexDeprecated,

- Value::CreateIntegerValue(1));

+ new base::FundamentalValue(1));

// We insert the ids in reserve order so that we have to deal with the

// element on the 2nd page before the 1st page is seen.

@@ -281,10 +281,10 @@ class ExtensionSortingMigrateAppIndexInvalid

static_cast<ExtensionScopedPrefs*>(prefs());

scoped_prefs->UpdateExtensionPref(extension1()->id(),

kPrefAppLaunchIndexDeprecated,

- Value::CreateIntegerValue(0));

+ new base::FundamentalValue(0));

scoped_prefs->UpdateExtensionPref(extension1()->id(),

kPrefPageIndexDeprecated,

- Value::CreateIntegerValue(-1));

+ new base::FundamentalValue(-1));

extensions::ExtensionIdList ids;

ids.push_back(extension1()->id());