chrome/browser/extensions/extension_special_storage_policy_unittest.cc - Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_special_storage_policy_unittest.cc

Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Removed C-style casts. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/extension_special_storage_policy_unittest.cc

diff --git a/chrome/browser/extensions/extension_special_storage_policy_unittest.cc b/chrome/browser/extensions/extension_special_storage_policy_unittest.cc

index 74f34fee76f9e46044f6ba1dbc958dadafca889c..a849f2a923a9a55fbedaec5dccdc7be63e7f2aed 100644

--- a/chrome/browser/extensions/extension_special_storage_policy_unittest.cc

+++ b/chrome/browser/extensions/extension_special_storage_policy_unittest.cc

@@ -105,8 +105,8 @@ class ExtensionSpecialStoragePolicyTest : public testing::Test {

manifest.SetString(keys::kVersion, "1");

manifest.SetString(keys::kLaunchWebURL, "http://explicit/protected/start");

base::ListValue* list = new base::ListValue();

- list->Append(Value::CreateStringValue("http://explicit/protected"));

- list->Append(Value::CreateStringValue("*://*.wildcards/protected"));

+ list->Append(new base::StringValue("http://explicit/protected"));

+ list->Append(new base::StringValue("*://*.wildcards/protected"));

manifest.Set(keys::kWebURLs, list);

std::string error;

scoped_refptr<Extension> protected_app = Extension::Create(

@@ -127,11 +127,11 @@ class ExtensionSpecialStoragePolicyTest : public testing::Test {

manifest.SetString(keys::kVersion, "1");

manifest.SetString(keys::kLaunchWebURL, "http://explicit/unlimited/start");

base::ListValue* list = new base::ListValue();

- list->Append(Value::CreateStringValue("unlimitedStorage"));

+ list->Append(new base::StringValue("unlimitedStorage"));

manifest.Set(keys::kPermissions, list);

list = new base::ListValue();

- list->Append(Value::CreateStringValue("http://explicit/unlimited"));

- list->Append(Value::CreateStringValue("*://*.wildcards/unlimited"));

+ list->Append(new base::StringValue("http://explicit/unlimited"));

+ list->Append(new base::StringValue("*://*.wildcards/unlimited"));

manifest.Set(keys::kWebURLs, list);

std::string error;

scoped_refptr<Extension> unlimited_app = Extension::Create(

« no previous file with comments | « chrome/browser/extensions/extension_sorting_unittest.cc ('k') | chrome/browser/extensions/menu_manager.h » ('j') | no next file with comments »