chrome/browser/extensions/extension_sorting.cc - Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_sorting.cc

Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Removed C-style casts. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_service_unittest.cc ('k') | chrome/browser/extensions/extension_sorting_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_sorting.cc

diff --git a/chrome/browser/extensions/extension_sorting.cc b/chrome/browser/extensions/extension_sorting.cc

index 1af664016967990b99bdc57465f3227b3e67aa85..fa17dacd6c6856f5815e19b85d67583c5cc3f4ac 100644

--- a/chrome/browser/extensions/extension_sorting.cc

+++ b/chrome/browser/extensions/extension_sorting.cc

@@ -306,7 +306,7 @@ void ExtensionSorting::SetAppLaunchOrdinal(

AddOrdinalMapping(extension_id, page_ordinal, new_app_launch_ordinal);

Value* new_value = new_app_launch_ordinal.IsValid() ?

- Value::CreateStringValue(new_app_launch_ordinal.ToInternalValue()) :

+ new base::StringValue(new_app_launch_ordinal.ToInternalValue()) :

NULL;

extension_scoped_prefs_->UpdateExtensionPref(

@@ -385,7 +385,7 @@ void ExtensionSorting::SetPageOrdinal(

AddOrdinalMapping(extension_id, new_page_ordinal, app_launch_ordinal);

Value* new_value = new_page_ordinal.IsValid() ?

- Value::CreateStringValue(new_page_ordinal.ToInternalValue()) :

+ new base::StringValue(new_page_ordinal.ToInternalValue()) :

NULL;

extension_scoped_prefs_->UpdateExtensionPref(

« no previous file with comments | « chrome/browser/extensions/extension_service_unittest.cc ('k') | chrome/browser/extensions/extension_sorting_unittest.cc » ('j') | no next file with comments »