Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(816)

Unified Diff: chrome/browser/extensions/api/developer_private/developer_private_api.cc

Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Trying one last time get past Base Files Missing. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/developer_private/developer_private_api.cc
diff --git a/chrome/browser/extensions/api/developer_private/developer_private_api.cc b/chrome/browser/extensions/api/developer_private/developer_private_api.cc
index a7d8732b43b2e064c5206a9c0def71a3491487ce..b12a16c18cda6b939c08825590c55d724838f150 100644
--- a/chrome/browser/extensions/api/developer_private/developer_private_api.cc
+++ b/chrome/browser/extensions/api/developer_private/developer_private_api.cc
@@ -250,7 +250,7 @@ bool DeveloperPrivateAutoUpdateFunction::RunImpl() {
ExtensionUpdater* updater = GetExtensionUpdater(profile());
if (updater)
updater->CheckNow(ExtensionUpdater::CheckParams());
- SetResult(Value::CreateBooleanValue(true));
+ SetResult(new base::FundamentalValue(true));
return true;
}
@@ -1095,7 +1095,7 @@ void DeveloperPrivateLoadProjectFunction::GetUnpackedExtension(
const Extension* extension = GetExtensionByPath(extensions, path);
bool success = true;
if (extension) {
- SetResult(base::Value::CreateStringValue(extension->id()));
+ SetResult(new base::StringValue(extension->id()));
} else {
SetError("unable to load the project");
success = false;
@@ -1154,7 +1154,7 @@ bool DeveloperPrivateChoosePathFunction::RunImpl() {
void DeveloperPrivateChoosePathFunction::FileSelected(
const base::FilePath& path) {
- SetResult(base::Value::CreateStringValue(
+ SetResult(new base::StringValue(
UTF16ToUTF8(path.LossyDisplayName())));
SendResponse(true);
Release();

Powered by Google App Engine
This is Rietveld 408576698