chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc - Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc

Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Trying one last time get past Base Files Missing. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc ('k') | chrome/browser/extensions/api/developer_private/developer_private_api.cc » ('j') | chrome/browser/extensions/api/extension_action/extension_action_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc

diff --git a/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc b/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc

index aa9bf22da9c3f8979d7cbb60f6c94ac7fe25c3d4..2b345147fd9fce7aabd211ce0f58a87f82b92e25 100644

--- a/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc

+++ b/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc

@@ -95,7 +95,7 @@ class WebRequestRulesRegistryTest : public testing::Test {

// https://www.example.com and cancels it

linked_ptr<RulesRegistry::Rule> CreateRule1() {

base::ListValue* scheme_http = new base::ListValue();

- scheme_http->Append(Value::CreateStringValue("http"));

+ scheme_http->Append(new base::StringValue("http"));

base::DictionaryValue* http_condition_dict = new base::DictionaryValue();

http_condition_dict->Set(keys2::kSchemesKey, scheme_http);

http_condition_dict->SetString(keys2::kHostSuffixKey, "example.com");

@@ -105,7 +105,7 @@ class WebRequestRulesRegistryTest : public testing::Test {

keys::kRequestMatcherType);

base::ListValue* scheme_https = new base::ListValue();

- scheme_http->Append(Value::CreateStringValue("https"));

+ scheme_http->Append(new base::StringValue("https"));

base::DictionaryValue* https_condition_dict = new base::DictionaryValue();

https_condition_dict->Set(keys2::kSchemesKey, scheme_https);

https_condition_dict->SetString(keys2::kHostSuffixKey, "example.com");