c/b/extensions, json_schema_compiler: Do not use Value::Create*.

chrome/browser/extensions/api/extension_action/extension_action_api.cc

Index: chrome/browser/extensions/api/extension_action/extension_action_api.cc
diff --git a/chrome/browser/extensions/api/extension_action/extension_action_api.cc b/chrome/browser/extensions/api/extension_action/extension_action_api.cc
index a4c5a2c225c5e3da8dbb13f67e54a7ba21ca0289..b1278f02746256ebeba92c059b992c0b97032372 100644
--- a/chrome/browser/extensions/api/extension_action/extension_action_api.cc
+++ b/chrome/browser/extensions/api/extension_action/extension_action_api.cc
@@ -253,7 +253,7 @@ void ExtensionActionAPI::SetBrowserActionVisibility(
 
   prefs->UpdateExtensionPref(extension_id,
                              kBrowserActionVisible,
-                             Value::CreateBooleanValue(visible));
+                             new base::FundamentalValue(visible));
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_EXTENSION_BROWSER_ACTION_VISIBILITY_CHANGED,
       content::Source<ExtensionPrefs>(prefs),
@@ -655,28 +655,28 @@ bool ExtensionActionSetBadgeBackgroundColorFunction::RunExtensionAction() {
 }
 
 bool ExtensionActionGetTitleFunction::RunExtensionAction() {
-  SetResult(Value::CreateStringValue(extension_action_->GetTitle(tab_id_)));
+  SetResult(new base::StringValue(extension_action_->GetTitle(tab_id_)));
   return true;
 }
 
 bool ExtensionActionGetPopupFunction::RunExtensionAction() {
   SetResult(
-      Value::CreateStringValue(extension_action_->GetPopupUrl(tab_id_).spec()));
+      new base::StringValue(extension_action_->GetPopupUrl(tab_id_).spec()));
   return true;
 }
 
 bool ExtensionActionGetBadgeTextFunction::RunExtensionAction() {
-  SetResult(Value::CreateStringValue(extension_action_->GetBadgeText(tab_id_)));
+  SetResult(new base::StringValue(extension_action_->GetBadgeText(tab_id_)));
   return true;
 }
 
 bool ExtensionActionGetBadgeBackgroundColorFunction::RunExtensionAction() {
   base::ListValue* list = new base::ListValue();
   SkColor color = extension_action_->GetBadgeBackgroundColor(tab_id_);
-  list->Append(Value::CreateIntegerValue(SkColorGetR(color)));
-  list->Append(Value::CreateIntegerValue(SkColorGetG(color)));
-  list->Append(Value::CreateIntegerValue(SkColorGetB(color)));
-  list->Append(Value::CreateIntegerValue(SkColorGetA(color)));
+  list->Append(new base::FundamentalValue((int)SkColorGetR(color)));

[not at google - send to devlin, 2013/08/12 20:59:48]

do you really need a cast here? if so it sadly needs to be static_cast.

[dhnishi (use Chromium), 2013/08/12 23:40:40]

Done.

It unfortunately didn't know which FundamentalValue constructor to use without
casting. It wasn't a problem before because the CreateIntegerValue just knew,
but that it's just an overloaded constructor it was ambiguous.

+  list->Append(new base::FundamentalValue((int)SkColorGetG(color)));
+  list->Append(new base::FundamentalValue((int)SkColorGetB(color)));
+  list->Append(new base::FundamentalValue((int)SkColorGetA(color)));
   SetResult(list);
   return true;
 }