Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4004)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/config/dcheck_always_on.gni

Issue 2288473002: Implement Dump-on-DCHECK (via a new LogSeverity). (Closed)
Patch Set: Migrate some tests to EXPECT_DCHECK_DEATH Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/config/BUILD.gn ('K') | « build/config/BUILD.gn ('k') | components/browser_sync/profile_sync_components_factory_impl.cc » ('j') | third_party/WebKit/Source/wtf/Assertions.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/dcheck_always_on.gni
diff --git a/build/config/dcheck_always_on.gni b/build/config/dcheck_always_on.gni
index 60672cdf50e6d22e5bff5b04d972976b084e3f05..2012371dd3a739de48d51fd7e2b8c91af7e68133 100644
--- a/build/config/dcheck_always_on.gni
+++ b/build/config/dcheck_always_on.gni
@@ -5,4 +5,9 @@
declare_args() {
# Set to true to enable dcheck in Release builds.
dcheck_always_on = false
+
+ # Set to true to have the first failed dcheck cause a dump to be
+ # uploaded, without crashing. Implies dcheck_always_on, but does not
Wez 2016/12/19 23:57:46 Note to self: Correct implies->requires
+ # actually enable logging of dcheck failures.
+ dump_on_first_dcheck = false
}
« build/config/BUILD.gn ('K') | « build/config/BUILD.gn ('k') | components/browser_sync/profile_sync_components_factory_impl.cc » ('j') | third_party/WebKit/Source/wtf/Assertions.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698