build/config/dcheck_always_on.gni - Issue 2288473002: Implement Dump-on-DCHECK (via a new LogSeverity).

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/config/dcheck_always_on.gni

Issue 2288473002: Implement Dump-on-DCHECK (via a new LogSeverity). (Closed)

Patch Set: Migrate some tests to EXPECT_DCHECK_DEATH Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # Copyright (c) 2016 The Chromium Authors. All rights reserved.	1 # Copyright (c) 2016 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 declare_args() {	5 declare_args() {

6 # Set to true to enable dcheck in Release builds.	6 # Set to true to enable dcheck in Release builds.

7 dcheck_always_on = false	7 dcheck_always_on = false

	8

	9 # Set to true to have the first failed dcheck cause a dump to be

	10 # uploaded, without crashing. Implies dcheck_always_on, but does not
	Wez 2016/12/19 23:57:46 Note to self: Correct implies->requires Note to self: Correct implies->requires
	11 # actually enable logging of dcheck failures.

	12 dump_on_first_dcheck = false

8 }	13 }

OLD	NEW