Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3369)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/config/BUILD.gn

Issue 2288473002: Implement Dump-on-DCHECK (via a new LogSeverity). (Closed)
Patch Set: Migrate some tests to EXPECT_DCHECK_DEATH Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/test/gtest_util.h ('K') | « base/test/gtest_util.h ('k') | build/config/dcheck_always_on.gni » ('j') | build/config/dcheck_always_on.gni » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/BUILD.gn
diff --git a/build/config/BUILD.gn b/build/config/BUILD.gn
index 80427f26a087b631031ad3a45bd017547898a4a9..59ccc671fc3849b418da1124ac5db4c1a9623565 100644
--- a/build/config/BUILD.gn
+++ b/build/config/BUILD.gn
@@ -58,9 +58,18 @@ declare_args() {
config("feature_flags") {
# Don't use deprecated V8 APIs anywhere.
defines = [ "V8_DEPRECATION_WARNINGS" ]
+
if (dcheck_always_on) {
defines += [ "DCHECK_ALWAYS_ON=1" ]
}
+
+ # This will cause DCHECKs to dump-without-crashing. See crbug.com/596231.
+ if (dump_on_first_dcheck) {
+ assert(is_debug || dcheck_always_on,
+ "dump_on_first_check requires is_debug, or dcheck_always_on")
+ defines += [ "DCHECK_IS_DUMP_WITHOUT_CRASH=1" ]
Wez 2016/12/19 23:57:46 Q: Suggestions on better naming welcome!
+ }
+
if (use_udev) {
# TODO(brettw) should probably be "=1".
defines += [ "USE_UDEV" ]
« base/test/gtest_util.h ('K') | « base/test/gtest_util.h ('k') | build/config/dcheck_always_on.gni » ('j') | build/config/dcheck_always_on.gni » ('J')

Powered by Google App Engine
This is Rietveld 408576698