Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1150)

Side by Side Diff: build/config/BUILD.gn

Issue 2288473002: Implement Dump-on-DCHECK (via a new LogSeverity). (Closed)
Patch Set: Migrate some tests to EXPECT_DCHECK_DEATH Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/allocator.gni") 5 import("//build/config/allocator.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/chromecast_build.gni") 7 import("//build/config/chromecast_build.gni")
8 import("//build/config/crypto.gni") 8 import("//build/config/crypto.gni")
9 import("//build/config/dcheck_always_on.gni") 9 import("//build/config/dcheck_always_on.gni")
10 import("//build/config/features.gni") 10 import("//build/config/features.gni")
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 # 51 #
52 # See //build/buildflag_header.gni for inntructions on generating headers. 52 # See //build/buildflag_header.gni for inntructions on generating headers.
53 # 53 #
54 # This will also allow you to scope your build flag to a BUILD.gn file (or a 54 # This will also allow you to scope your build flag to a BUILD.gn file (or a
55 # .gni file if you need it from more than one place) rather than making global 55 # .gni file if you need it from more than one place) rather than making global
56 # flags. See //build/config/BUILDCONFIG.gn for advice on where to define 56 # flags. See //build/config/BUILDCONFIG.gn for advice on where to define
57 # build flags. 57 # build flags.
58 config("feature_flags") { 58 config("feature_flags") {
59 # Don't use deprecated V8 APIs anywhere. 59 # Don't use deprecated V8 APIs anywhere.
60 defines = [ "V8_DEPRECATION_WARNINGS" ] 60 defines = [ "V8_DEPRECATION_WARNINGS" ]
61
61 if (dcheck_always_on) { 62 if (dcheck_always_on) {
62 defines += [ "DCHECK_ALWAYS_ON=1" ] 63 defines += [ "DCHECK_ALWAYS_ON=1" ]
63 } 64 }
65
66 # This will cause DCHECKs to dump-without-crashing. See crbug.com/596231.
67 if (dump_on_first_dcheck) {
68 assert(is_debug || dcheck_always_on,
69 "dump_on_first_check requires is_debug, or dcheck_always_on")
70 defines += [ "DCHECK_IS_DUMP_WITHOUT_CRASH=1" ]
Wez 2016/12/19 23:57:46 Q: Suggestions on better naming welcome!
71 }
72
64 if (use_udev) { 73 if (use_udev) {
65 # TODO(brettw) should probably be "=1". 74 # TODO(brettw) should probably be "=1".
66 defines += [ "USE_UDEV" ] 75 defines += [ "USE_UDEV" ]
67 } 76 }
68 if (ui_compositor_image_transport) { 77 if (ui_compositor_image_transport) {
69 # TODO(brettw) should probably be "=1". 78 # TODO(brettw) should probably be "=1".
70 defines += [ "UI_COMPOSITOR_IMAGE_TRANSPORT" ] 79 defines += [ "UI_COMPOSITOR_IMAGE_TRANSPORT" ]
71 } 80 }
72 if (use_ash) { 81 if (use_ash) {
73 defines += [ "USE_ASH=1" ] 82 defines += [ "USE_ASH=1" ]
(...skipping 319 matching lines...) Expand 10 before | Expand all | Expand 10 after
393 # 402 #
394 # TODO(sof): determine VS2015 status and retire the setting from all 403 # TODO(sof): determine VS2015 status and retire the setting from all
395 # precompiled configurations. 404 # precompiled configurations.
396 cflags_c = [ "/wd4206" ] 405 cflags_c = [ "/wd4206" ]
397 } else if (is_mac) { 406 } else if (is_mac) {
398 precompiled_header = "build/precompile.h" 407 precompiled_header = "build/precompile.h"
399 precompiled_source = "//build/precompile.h" 408 precompiled_source = "//build/precompile.h"
400 } 409 }
401 } 410 }
402 } 411 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698