Ignore exceptions in embed extractors

Ignore exceptions in embed extractors

When embed extractors peek into iframes, exceptions might be thrown if
same-origin policy is violated, like sandboxed iframes or in MHTML files.

R=mdjones@chromium.org

Committed: 85447bdae507a4a91597fac1cdc72f76963d9f34

[wychen, 2016-08-29 18:46:17]

wychen@chromium.org changed reviewers:
+ mdjones@chromium.org

[wychen, 2016-08-29 18:46:18]

PTAL

[mdjones, 2016-08-29 20:52:51]

lgtm % nit. The embed extractors are the only ones that would do this right?

https://codereview.chromium.org/2288143003/diff/1/java/org/chromium/distiller...
File java/org/chromium/distiller/webdocument/DomConverter.java (right):

https://codereview.chromium.org/2288143003/diff/1/java/org/chromium/distiller...
java/org/chromium/distiller/webdocument/DomConverter.java:103:
LogUtil.logToConsole("Exception happened in EmbedExtractors: " +
exception.getMessage());
100+ chars?

[wychen, 2016-08-29 20:59:01]

On 2016/08/29 20:52:51, mdjones wrote:
> lgtm % nit. The embed extractors are the only ones that would do this right?

The embed extractors would be the only place we access inside iframes after this
CL:
https://codereview.chromium.org/2287113005

[mdjones, 2016-08-29 21:31:29]

still lgtm

[wychen, 2016-08-29 21:39:16]

Description was changed from

==========
Ignore exceptions in embed extractors

When embed extractors peek into iframes, exceptions might be thrown if
same-origin policy is violated, like sandboxed iframes or in MHTML files.

This should not change the results in production for most pages.

BUG=
==========

to

==========
Ignore exceptions in embed extractors

When embed extractors peek into iframes, exceptions might be thrown if
same-origin policy is violated, like sandboxed iframes or in MHTML files.
==========

[wychen, 2016-08-29 21:42:02]

Description was changed from

==========
Ignore exceptions in embed extractors

When embed extractors peek into iframes, exceptions might be thrown if
same-origin policy is violated, like sandboxed iframes or in MHTML files.
==========

to

==========
Ignore exceptions in embed extractors

When embed extractors peek into iframes, exceptions might be thrown if
same-origin policy is violated, like sandboxed iframes or in MHTML files.

R=mdjones@chromium.org

Committed: 85447bdae507a4a91597fac1cdc72f76963d9f34
==========

[wychen, 2016-08-29 21:42:04]

Committed patchset #2 (id:20001) manually as
85447bdae507a4a91597fac1cdc72f76963d9f34 (presubmit successful).