Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 2288143003: Ignore exceptions in embed extractors (Closed)

Created:
4 years, 3 months ago by wychen
Modified:
4 years, 3 months ago
Reviewers:
mdjones
Base URL:
git@github.com:chromium/dom-distiller.git@noiframe
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Ignore exceptions in embed extractors When embed extractors peek into iframes, exceptions might be thrown if same-origin policy is violated, like sandboxed iframes or in MHTML files. R=mdjones@chromium.org Committed: 85447bdae507a4a91597fac1cdc72f76963d9f34

Patch Set 1 #

Total comments: 1

Patch Set 2 : line wrapping #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -8 lines) Patch
M java/org/chromium/distiller/webdocument/DomConverter.java View 1 1 chunk +13 lines, -8 lines 0 comments Download
M javatests/org/chromium/distiller/ContentExtractorTest.java View 1 chunk +6 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
wychen
PTAL
4 years, 3 months ago (2016-08-29 18:46:18 UTC) #2
mdjones
lgtm % nit. The embed extractors are the only ones that would do this right? ...
4 years, 3 months ago (2016-08-29 20:52:51 UTC) #3
wychen
On 2016/08/29 20:52:51, mdjones wrote: > lgtm % nit. The embed extractors are the only ...
4 years, 3 months ago (2016-08-29 20:59:01 UTC) #4
mdjones
still lgtm
4 years, 3 months ago (2016-08-29 21:31:29 UTC) #5
wychen
4 years, 3 months ago (2016-08-29 21:42:04 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
85447bdae507a4a91597fac1cdc72f76963d9f34 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698