Skip unrecognized iframes

Skip unrecognized iframes

IFrames are usually useless unless they are recognized by embed extractors.
The result is mostly good. The exception is documented at:
http://crbug.com/641678

Score changes:

https://x20web.corp.google.com/~wychen/domdistillerscore/noiframe/knowledge.html
Average precision: 0.959 → 0.961

https://x20web.corp.google.com/~wychen/domdistillerscore/noiframe/multi-page.html
Average precision: 0.746 → 0.746+

https://x20web.corp.google.com/~wychen/domdistillerscore/noiframe/page-links.html
Average precision: 0.919 → 0.920

https://x20web.corp.google.com/~wychen/domdistillerscore/noiframe/reader-golden.html
Average precision: 0.945 → 0.946

The recall is not changed because less things are extracted.

BUG=641678
R=mdjones@chromium.org

Committed: 50efabe82fa19b3bb9d44e8812907d447d9746a5

[wychen, 2016-08-29 18:45:59]

wychen@chromium.org changed reviewers:
+ mdjones@chromium.org

[wychen, 2016-08-29 18:46:00]

PTAL

[mdjones, 2016-08-29 20:58:22]

https://codereview.chromium.org/2287113005/diff/1/java/org/chromium/distiller...
File java/org/chromium/distiller/webdocument/DomConverter.java (right):

https://codereview.chromium.org/2287113005/diff/1/java/org/chromium/distiller...
java/org/chromium/distiller/webdocument/DomConverter.java:103: if
(e.getTagName().equals("IFRAME")) {
Can we just add "IFRAME" to the switch below?

[wychen, 2016-08-29 21:21:09]

https://codereview.chromium.org/2287113005/diff/1/java/org/chromium/distiller...
File java/org/chromium/distiller/webdocument/DomConverter.java (right):

https://codereview.chromium.org/2287113005/diff/1/java/org/chromium/distiller...
java/org/chromium/distiller/webdocument/DomConverter.java:103: if
(e.getTagName().equals("IFRAME")) {
On 2016/08/29 20:58:22, mdjones wrote:
> Can we just add "IFRAME" to the switch below?

Done.

[mdjones, 2016-08-29 21:32:52]

lgtm

[wychen, 2016-08-29 21:38:00]

Description was changed from

==========
Skip unrecognized iframes

IFrames are usually useless unless they are recognized by embed extractors.
The result is mostly good. The exception is documented at:
http://crbug.com/641678

Score changes:

https://x20web.corp.google.com/~wychen/domdistillerscore/noiframe/knowledge.html
Average precision: 0.959 → 0.961

https://x20web.corp.google.com/~wychen/domdistillerscore/noiframe/multi-page....
Average precision: 0.746 → 0.746+

https://x20web.corp.google.com/~wychen/domdistillerscore/noiframe/page-links....
Average precision: 0.919 → 0.920

https://x20web.corp.google.com/~wychen/domdistillerscore/noiframe/reader-gold...
Average precision: 0.945 → 0.946

The recall is not changed because less things are extracted.

BUG=641678
==========

to

==========
Skip unrecognized iframes

IFrames are usually useless unless they are recognized by embed extractors.
The result is mostly good. The exception is documented at:
http://crbug.com/641678

Score changes:

https://x20web.corp.google.com/~wychen/domdistillerscore/noiframe/knowledge.html
Average precision: 0.959 → 0.961

https://x20web.corp.google.com/~wychen/domdistillerscore/noiframe/multi-page....
Average precision: 0.746 → 0.746+

https://x20web.corp.google.com/~wychen/domdistillerscore/noiframe/page-links....
Average precision: 0.919 → 0.920

https://x20web.corp.google.com/~wychen/domdistillerscore/noiframe/reader-gold...
Average precision: 0.945 → 0.946

The recall is not changed because less things are extracted.

BUG=641678
R=mdjones@chromium.org

Committed: 50efabe82fa19b3bb9d44e8812907d447d9746a5
==========

[wychen, 2016-08-29 21:38:02]

Committed patchset #2 (id:20001) manually as
50efabe82fa19b3bb9d44e8812907d447d9746a5 (presubmit successful).