Ignore exceptions in embed extractors

java/org/chromium/distiller/webdocument/DomConverter.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.distiller.webdocument;
 
 import org.chromium.distiller.DomUtil;
 import org.chromium.distiller.DomWalker;
 import org.chromium.distiller.LogUtil;
 import org.chromium.distiller.TableClassifier;
@@ skipping 69 matching lines @@
         boolean visible = DomUtil.isVisible(e);
         logVisibilityInfo(e, visible);
         if (!visible) {
             hiddenElements.add(e);
             return false;
         }
 
         // Node-type specific extractors check for elements they are interested in here. Everything
         // else will be filtered through the switch below.
 
-        // Check for embedded elements that might be extracted.
-        if (embedTagNames.contains(e.getTagName())) {
-            // If the tag is marked as interesting, check the extractors.
-            for (EmbedExtractor extractor : extractors) {
-                WebElement embed = extractor.extract(e);
-                if (embed != null) {
-                    builder.embed(embed);
-                    return false;
+        try {
+            // Check for embedded elements that might be extracted.
+            if (embedTagNames.contains(e.getTagName())) {
+                // If the tag is marked as interesting, check the extractors.
+                for (EmbedExtractor extractor : extractors) {
+                    WebElement embed = extractor.extract(e);
+                    if (embed != null) {
+                        builder.embed(embed);
+                        return false;
+                    }
                 }
             }
+        } catch (Exception exception) {
+            LogUtil.logToConsole("Exception happened in EmbedExtractors: " + exception.getMessage());

[mdjones, 2016/08/29 20:52:51]

100+ chars?

         }
 
         // Skip IFRAMEs not recognized by EmbedExtractors.
         if (e.getTagName().equals("IFRAME")) {
             return false;
         }
 
         // Create a placeholder for the elements we want to preserve.
         if (WebTag.canBeNested(e.getTagName())) {
             builder.tag(new WebTag(e.getTagName(), WebTag.TagType.START));
@@ skipping 66 matching lines @@
         Element parent = e.getParentElement();
         LogUtil.logToConsole("TABLE: " + type +
                 ", id=" + e.getId() +
                 ", class=" + e.getClassName() +
                 ", parent=[" + parent.getTagName() +
                 ", id=" + parent.getId() +
                 ", class=" + parent.getClassName() +
                 "]");
     }
 }