Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Unified Diff: components/spellcheck/browser/spellcheck_action.cc

Issue 2287733002: Switch //components away from base::ListValue::Append(Value*) overload. (Closed)
Patch Set: Test fix Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/spellcheck/browser/spellcheck_action.cc
diff --git a/components/spellcheck/browser/spellcheck_action.cc b/components/spellcheck/browser/spellcheck_action.cc
index 55ac779fd973b397776076b4249119c37cca9fec..f34001b8fd9d94fd6b12f42fe221114de403f5a5 100644
--- a/components/spellcheck/browser/spellcheck_action.cc
+++ b/components/spellcheck/browser/spellcheck_action.cc
@@ -39,8 +39,8 @@ void SpellcheckAction::Finalize() {
}
}
-base::DictionaryValue* SpellcheckAction::Serialize() const {
- base::DictionaryValue* result = new base::DictionaryValue;
+std::unique_ptr<base::DictionaryValue> SpellcheckAction::Serialize() const {
+ std::unique_ptr<base::DictionaryValue> result(new base::DictionaryValue);
switch (type_) {
case TYPE_SELECT:
result->SetString("actionType", "SELECT");

Powered by Google App Engine
This is Rietveld 408576698