components/sync/device_info/device_info.h - Issue 2287733002: Switch //components away from base::ListValue::Append(Value*) overload.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/device_info/device_info.h

Issue 2287733002: Switch //components away from base::ListValue::Append(Value*) overload. (Closed)

Patch Set: Test fix Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/device_info/device_info.h

diff --git a/components/sync/device_info/device_info.h b/components/sync/device_info/device_info.h

index 638020771e350558fdfe770de650d7c50f5deacd..664741e3ee1941c0cd66b90db95417d6ce135333 100644

--- a/components/sync/device_info/device_info.h

+++ b/components/sync/device_info/device_info.h

@@ -72,7 +72,7 @@ class DeviceInfo {

// Converts the |DeviceInfo| values to a JS friendly DictionaryValue,

// which extension APIs can expose to third party apps.

- base::DictionaryValue* ToValue();

+ std::unique_ptr<base::DictionaryValue> ToValue();

private:

const std::string guid_;