Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(834)

Unified Diff: components/spellcheck/browser/spellcheck_action.h

Issue 2287733002: Switch //components away from base::ListValue::Append(Value*) overload. (Closed)
Patch Set: Test fix Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/spellcheck/browser/spellcheck_action.h
diff --git a/components/spellcheck/browser/spellcheck_action.h b/components/spellcheck/browser/spellcheck_action.h
index 5ed80f2cf7353508480105e4b9e5007ca2b3cd2c..2320da671f9a2f547fce426614baab13ea3ee1f8 100644
--- a/components/spellcheck/browser/spellcheck_action.h
+++ b/components/spellcheck/browser/spellcheck_action.h
@@ -5,6 +5,8 @@
#ifndef COMPONENTS_SPELLCHECK_BROWSER_SPELLCHECK_ACTION_H_
#define COMPONENTS_SPELLCHECK_BROWSER_SPELLCHECK_ACTION_H_
+#include <memory>
+
#include "base/strings/string16.h"
namespace base {
@@ -58,9 +60,8 @@ class SpellcheckAction {
// nothing.
void Finalize();
- // Serializes the data in this object into a dictionary value. The caller owns
- // the result.
- base::DictionaryValue* Serialize() const;
+ // Serializes the data in this object into a dictionary value.
+ std::unique_ptr<base::DictionaryValue> Serialize() const;
void set_type(SpellcheckActionType type) { type_ = type; }
void set_index(int index) { index_ = index; }

Powered by Google App Engine
This is Rietveld 408576698