Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: components/search_engines/template_url_prepopulate_data_unittest.cc

Issue 2287733002: Switch //components away from base::ListValue::Append(Value*) overload. (Closed)
Patch Set: Test fix Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/search_engines/template_url_prepopulate_data_unittest.cc
diff --git a/components/search_engines/template_url_prepopulate_data_unittest.cc b/components/search_engines/template_url_prepopulate_data_unittest.cc
index acda60f229d04bf194c3dded75a38cc17198c04d..1a22c125b14cbc4eb3f54c7e78b37c93c3ecb9bf 100644
--- a/components/search_engines/template_url_prepopulate_data_unittest.cc
+++ b/components/search_engines/template_url_prepopulate_data_unittest.cc
@@ -132,7 +132,7 @@ TEST_F(TemplateURLPrepopulateDataTest, ProvidersFromPrefs) {
entry->SetString("favicon_url", "http://foi.com/favicon.ico");
entry->SetString("encoding", "UTF-8");
entry->SetInteger("id", 1001);
- overrides->Append(entry->DeepCopy());
+ overrides->Append(entry->CreateDeepCopy());
prefs_.SetUserPref(prefs::kSearchProviderOverrides, overrides);
int version = TemplateURLPrepopulateData::GetDataVersion(&prefs_);
@@ -163,7 +163,7 @@ TEST_F(TemplateURLPrepopulateDataTest, ProvidersFromPrefs) {
entry->Set("alternate_urls", alternate_urls);
entry->SetString("search_terms_replacement_key", "espv");
overrides = new base::ListValue;
- overrides->Append(entry->DeepCopy());
+ overrides->Append(entry->CreateDeepCopy());
prefs_.SetUserPref(prefs::kSearchProviderOverrides, overrides);
t_urls = TemplateURLPrepopulateData::GetPrepopulatedEngines(
@@ -187,17 +187,17 @@ TEST_F(TemplateURLPrepopulateDataTest, ProvidersFromPrefs) {
// Test that subsequent providers are loaded even if an intermediate
// provider has an incomplete configuration.
overrides = new base::ListValue;
- overrides->Append(entry->DeepCopy());
+ overrides->Append(entry->CreateDeepCopy());
entry->SetInteger("id", 1002);
entry->SetString("name", "bar");
entry->SetString("keyword", "bark");
entry->SetString("encoding", std::string());
- overrides->Append(entry->DeepCopy());
+ overrides->Append(entry->CreateDeepCopy());
entry->SetInteger("id", 1003);
entry->SetString("name", "baz");
entry->SetString("keyword", "bazk");
entry->SetString("encoding", "UTF-8");
- overrides->Append(entry->DeepCopy());
+ overrides->Append(entry->CreateDeepCopy());
prefs_.SetUserPref(prefs::kSearchProviderOverrides, overrides);
t_urls =

Powered by Google App Engine
This is Rietveld 408576698