Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2080)

Unified Diff: components/search_engines/default_search_manager_unittest.cc

Issue 2287733002: Switch //components away from base::ListValue::Append(Value*) overload. (Closed)
Patch Set: Test fix Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/search_engines/default_search_manager_unittest.cc
diff --git a/components/search_engines/default_search_manager_unittest.cc b/components/search_engines/default_search_manager_unittest.cc
index 682b7144979bd24cf4b93bb185fc7a132f3cc497..99792c1a83f6afa47e3adfb3046783a0df347b97 100644
--- a/components/search_engines/default_search_manager_unittest.cc
+++ b/components/search_engines/default_search_manager_unittest.cc
@@ -67,19 +67,19 @@ void SetOverrides(user_prefs::TestingPrefServiceSyncable* prefs, bool update) {
alternate_urls->AppendString("http://foo.com/alternate?q={searchTerms}");
entry->Set("alternate_urls", alternate_urls);
entry->SetString("search_terms_replacement_key", "espv");
- overrides->Append(entry->DeepCopy());
+ overrides->Append(entry->CreateDeepCopy());
entry.reset(new base::DictionaryValue);
entry->SetInteger("id", 1002);
entry->SetString("name", update ? "new_bar" : "bar");
entry->SetString("keyword", update ? "new_bark" : "bark");
entry->SetString("encoding", std::string());
- overrides->Append(entry->DeepCopy());
+ overrides->Append(entry->CreateDeepCopy());
entry->SetInteger("id", 1003);
entry->SetString("name", "baz");
entry->SetString("keyword", "bazk");
entry->SetString("encoding", "UTF-8");
- overrides->Append(entry->DeepCopy());
+ overrides->Append(entry->CreateDeepCopy());
prefs->SetUserPref(prefs::kSearchProviderOverrides, overrides);
}

Powered by Google App Engine
This is Rietveld 408576698