components/signin/core/browser/about_signin_internals.h - Issue 2287733002: Switch //components away from base::ListValue::Append(Value*) overload.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/signin/core/browser/about_signin_internals.h

Issue 2287733002: Switch //components away from base::ListValue::Append(Value*) overload. (Closed)

Patch Set: Test fix Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/signin/core/browser/about_signin_internals.h

diff --git a/components/signin/core/browser/about_signin_internals.h b/components/signin/core/browser/about_signin_internals.h

index 9d77dd61b8783cc052191ececc9025e751d1657c..7af382bfc8e4b8cfc574c758fb3ed46611751faf 100644

--- a/components/signin/core/browser/about_signin_internals.h

+++ b/components/signin/core/browser/about_signin_internals.h

@@ -108,7 +108,7 @@ class AboutSigninInternals

TokenInfo(const std::string& consumer_id,

const OAuth2TokenService::ScopeSet& scopes);

~TokenInfo();

- base::DictionaryValue* ToValue() const;

+ std::unique_ptr<base::DictionaryValue> ToValue() const;

static bool LessThan(const TokenInfo* a, const TokenInfo* b);