Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: components/policy/core/common/schema_unittest.cc

Issue 2287733002: Switch //components away from base::ListValue::Append(Value*) overload. (Closed)
Patch Set: Test fix Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/policy/core/common/schema_unittest.cc
diff --git a/components/policy/core/common/schema_unittest.cc b/components/policy/core/common/schema_unittest.cc
index 9b40bad1503e34e3e164b7ea3591b4b199c78bc3..ef4c25eefaf343fc0f129e0871977bc303a6f961 100644
--- a/components/policy/core/common/schema_unittest.cc
+++ b/components/policy/core/common/schema_unittest.cc
@@ -656,8 +656,8 @@ TEST(SchemaTest, Validate) {
dict.SetString("one", "string");
dict.SetInteger("two", 2);
base::ListValue list;
- list.Append(dict.DeepCopy());
- list.Append(dict.DeepCopy());
+ list.Append(dict.CreateDeepCopy());
+ list.Append(dict.CreateDeepCopy());
bundle.Set("ArrayOfObjects", list.DeepCopy());
}
@@ -666,8 +666,8 @@ TEST(SchemaTest, Validate) {
list.AppendString("a string");
list.AppendString("another string");
base::ListValue listlist;
- listlist.Append(list.DeepCopy());
- listlist.Append(list.DeepCopy());
+ listlist.Append(list.CreateDeepCopy());
+ listlist.Append(list.CreateDeepCopy());
bundle.Set("ArrayOfArray", listlist.DeepCopy());
}

Powered by Google App Engine
This is Rietveld 408576698