components/devtools_http_handler/devtools_http_handler.h - Issue 2287733002: Switch //components away from base::ListValue::Append(Value*) overload.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/devtools_http_handler/devtools_http_handler.h

Issue 2287733002: Switch //components away from base::ListValue::Append(Value*) overload. (Closed)

Patch Set: Test fix Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/devtools_http_handler/devtools_http_handler.h

diff --git a/components/devtools_http_handler/devtools_http_handler.h b/components/devtools_http_handler/devtools_http_handler.h

index 559fc442a232ecd89e0f75df6684b73e5f2abb04..0faa8580bd81c312fbf493bf4dde98ac8ee8a006 100644

--- a/components/devtools_http_handler/devtools_http_handler.h

+++ b/components/devtools_http_handler/devtools_http_handler.h

@@ -123,7 +123,7 @@ class DevToolsHttpHandler {

std::string GetFrontendURLInternal(const std::string& target_id,

const std::string& host);

- base::DictionaryValue* SerializeDescriptor(

+ std::unique_ptr<base::DictionaryValue> SerializeDescriptor(

scoped_refptr<content::DevToolsAgentHost> agent_host,

const std::string& host);