Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: components/devtools_http_handler/devtools_http_handler.cc

Issue 2287733002: Switch //components away from base::ListValue::Append(Value*) overload. (Closed)
Patch Set: Test fix Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/devtools_http_handler/devtools_http_handler.cc
diff --git a/components/devtools_http_handler/devtools_http_handler.cc b/components/devtools_http_handler/devtools_http_handler.cc
index f1bf34f9b8d7b24843900be6da56af6c8c4474d2..86765589d896b12b2f9477baf3fdfa2c06e26129 100644
--- a/components/devtools_http_handler/devtools_http_handler.cc
+++ b/components/devtools_http_handler/devtools_http_handler.cc
@@ -887,10 +887,10 @@ void DevToolsHttpHandler::AcceptWebSocket(
base::Unretained(server_wrapper_), connection_id, request));
}
-base::DictionaryValue* DevToolsHttpHandler::SerializeDescriptor(
+std::unique_ptr<base::DictionaryValue> DevToolsHttpHandler::SerializeDescriptor(
scoped_refptr<DevToolsAgentHost> agent_host,
const std::string& host) {
- base::DictionaryValue* dictionary = new base::DictionaryValue;
+ std::unique_ptr<base::DictionaryValue> dictionary(new base::DictionaryValue);
std::string id = agent_host->GetId();
dictionary->SetString(kTargetIdField, id);
std::string parent_id = agent_host->GetParentId();

Powered by Google App Engine
This is Rietveld 408576698