components/data_reduction_proxy/core/common/data_reduction_proxy_event_store.cc - Issue 2287733002: Switch //components away from base::ListValue::Append(Value*) overload.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/common/data_reduction_proxy_event_store.cc

Issue 2287733002: Switch //components away from base::ListValue::Append(Value*) overload. (Closed)

Patch Set: Test fix Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/cloud_devices/common/description_items_inl.h ('K') | « components/cloud_devices/common/printer_description.cc ('k') | components/devtools_http_handler/devtools_http_handler.h » ('j') | components/error_page/common/localized_error.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/common/data_reduction_proxy_event_store.cc

diff --git a/components/data_reduction_proxy/core/common/data_reduction_proxy_event_store.cc b/components/data_reduction_proxy/core/common/data_reduction_proxy_event_store.cc

index 2d730a84c451a37f020b19e15f17dd9e5453253f..df8c57c6b6f86dff1b44d7a3c357f1fea41ae1cc 100644

--- a/components/data_reduction_proxy/core/common/data_reduction_proxy_event_store.cc

+++ b/components/data_reduction_proxy/core/common/data_reduction_proxy_event_store.cc

@@ -138,7 +138,7 @@ DataReductionProxyEventStore::GetSummaryValue() const {

auto events_list = base::MakeUnique<base::ListValue>();

for (const auto& event : stored_events_)

- events_list->Append(event->DeepCopy());

+ events_list->Append(event->CreateDeepCopy());

data_reduction_proxy_values->Set("events", std::move(events_list));

return data_reduction_proxy_values;

}