Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: components/cloud_devices/common/printer_description.cc

Issue 2287733002: Switch //components away from base::ListValue::Append(Value*) overload. (Closed)
Patch Set: Test fix Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cloud_devices/common/printer_description.cc
diff --git a/components/cloud_devices/common/printer_description.cc b/components/cloud_devices/common/printer_description.cc
index a5e03a0999ee9d6eb8c0662df369b59c5b3c4828..aa7fa38d51703e856414027737298b3f82dbc37b 100644
--- a/components/cloud_devices/common/printer_description.cc
+++ b/components/cloud_devices/common/printer_description.cc
@@ -7,6 +7,8 @@
#include <stddef.h>
#include <algorithm>
+#include <memory>
+#include <utility>
#include "base/json/json_reader.h"
#include "base/json/json_writer.h"
@@ -734,11 +736,12 @@ class PageRangeTraits : public ItemsTraits<kOptionPageRange> {
base::ListValue* list = new base::ListValue;
dict->Set(kPageRangeInterval, list);
for (size_t i = 0; i < option.size(); ++i) {
- base::DictionaryValue* interval = new base::DictionaryValue;
- list->Append(interval);
+ std::unique_ptr<base::DictionaryValue> interval(
+ new base::DictionaryValue);
interval->SetInteger(kPageRangeStart, option[i].start);
if (option[i].end < kMaxPageNumber)
interval->SetInteger(kPageRangeEnd, option[i].end);
+ list->Append(std::move(interval));
}
}
}

Powered by Google App Engine
This is Rietveld 408576698