Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(776)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 22875037: My clang now doesn't complain about !"foo". (Closed)

Created:
7 years, 4 months ago by mtklein
Modified:
7 years, 4 months ago
Reviewers:
borenet, robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

My clang now doesn't complain about !"foo". BUG= R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=10874

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -74 lines) Patch
M bench/GradientBench.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M bench/benchmain.cpp View 1 chunk +1 line, -1 line 0 comments Download
M experimental/StrokePathRenderer/GrStrokePathRenderer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkBitmapFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkFontHost.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M src/core/SkPath.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M src/core/SkPathRef.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkPictureRecord.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkStrokeRec.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/device/xps/SkXPSDevice.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M src/doc/SkDocument.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/GrAtlas.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDefaultPathRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/SkGrFontScaler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLUtil.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGpuGL_program.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/image/SkImagePriv.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/images/SkImageDecoder.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pathops/SkPathOpsTypes.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pdf/SkPDFUtils.h View 1 chunk +1 line, -1 line 0 comments Download
M src/utils/SkJSON.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/utils/SkLua.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/utils/SkPictureUtils.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/utils/ios/SkFontHost_iOS.mm View 4 chunks +5 lines, -5 lines 0 comments Download
M src/utils/ios/SkOSFile_iOS.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M src/utils/win/SkDWriteGeometrySink.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/AAClipTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ClampRangeTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PathTest.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M tools/flags/SkCommandLineFlags.h View 7 chunks +7 lines, -7 lines 0 comments Download
M tools/flags/SkCommandLineFlags.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
mtklein
7 years, 4 months ago (2013-08-22 15:29:00 UTC) #1
robertphillips
lgtm
7 years, 4 months ago (2013-08-22 15:34:35 UTC) #2
mtklein
7 years, 4 months ago (2013-08-22 15:38:02 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 manually as r10874 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698