Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Unified Diff: tests/PathTest.cpp

Issue 22875037: My clang now doesn't complain about !"foo". (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/ClampRangeTest.cpp ('k') | tools/flags/SkCommandLineFlags.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/PathTest.cpp
diff --git a/tests/PathTest.cpp b/tests/PathTest.cpp
index e6795d63c5909bb370a5080d0b96d0e87c34e24c..ed80d41aa2f4c999f02a8a4513ec989085ed060d 100644
--- a/tests/PathTest.cpp
+++ b/tests/PathTest.cpp
@@ -568,13 +568,13 @@ static void test_poly(skiatest::Reporter* reporter, const SkPath& path,
srcPts++;
break;
case SkPath::kQuad_Verb:
- REPORTER_ASSERT(reporter, !"unexpected quad verb");
+ REPORTER_ASSERT_MESSAGE(reporter, false, "unexpected quad verb");
break;
case SkPath::kConic_Verb:
- REPORTER_ASSERT(reporter, !"unexpected conic verb");
+ REPORTER_ASSERT_MESSAGE(reporter, false, "unexpected conic verb");
break;
case SkPath::kCubic_Verb:
- REPORTER_ASSERT(reporter, !"unexpected cubic verb");
+ REPORTER_ASSERT_MESSAGE(reporter, false, "unexpected cubic verb");
break;
case SkPath::kClose_Verb:
REPORTER_ASSERT(reporter, !firstTime);
@@ -2117,7 +2117,7 @@ static void test_raw_iter(skiatest::Reporter* reporter) {
lastWasClose = true;
break;
default:
- SkASSERT(!"unexpected verb");
+ SkDEBUGFAIL("unexpected verb");
}
expectedVerbs[numIterVerbs++] = nextVerb;
}
@@ -2170,7 +2170,7 @@ static void test_raw_iter(skiatest::Reporter* reporter) {
lastPt = lastMoveTo;
break;
default:
- SkASSERT(!"unexpected verb");
+ SkDEBUGFAIL("unexpected verb");
}
}
REPORTER_ASSERT(reporter, numIterPts == numPoints);
« no previous file with comments | « tests/ClampRangeTest.cpp ('k') | tools/flags/SkCommandLineFlags.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698