Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: tools/flags/SkCommandLineFlags.h

Issue 22875037: My clang now doesn't complain about !"foo". (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/PathTest.cpp ('k') | tools/flags/SkCommandLineFlags.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/flags/SkCommandLineFlags.h
diff --git a/tools/flags/SkCommandLineFlags.h b/tools/flags/SkCommandLineFlags.h
index 51af9334677b2c2f2ba458d152a785a634e76835..b0199f67173020357951a757fe97c866b0cebf08 100644
--- a/tools/flags/SkCommandLineFlags.h
+++ b/tools/flags/SkCommandLineFlags.h
@@ -304,7 +304,7 @@ public:
if (kString_FlagType == fFlagType) {
fStrings->reset();
} else {
- SkASSERT(!"Can only call resetStrings on kString_FlagType");
+ SkDEBUGFAIL("Can only call resetStrings on kString_FlagType");
}
}
@@ -312,7 +312,7 @@ public:
if (kString_FlagType == fFlagType) {
fStrings->append(string);
} else {
- SkASSERT(!"Can only append to kString_FlagType");
+ SkDEBUGFAIL("Can only append to kString_FlagType");
}
}
@@ -320,7 +320,7 @@ public:
if (kInt_FlagType == fFlagType) {
*fIntValue = value;
} else {
- SkASSERT(!"Can only call setInt on kInt_FlagType");
+ SkDEBUGFAIL("Can only call setInt on kInt_FlagType");
}
}
@@ -328,7 +328,7 @@ public:
if (kDouble_FlagType == fFlagType) {
*fDoubleValue = value;
} else {
- SkASSERT(!"Can only call setDouble on kDouble_FlagType");
+ SkDEBUGFAIL("Can only call setDouble on kDouble_FlagType");
}
}
@@ -336,7 +336,7 @@ public:
if (kBool_FlagType == fFlagType) {
*fBoolValue = value;
} else {
- SkASSERT(!"Can only call setBool on kBool_FlagType");
+ SkDEBUGFAIL("Can only call setBool on kBool_FlagType");
}
}
@@ -363,7 +363,7 @@ public:
result.printf("%2.2f", fDefaultDouble);
break;
default:
- SkASSERT(!"Invalid flag type");
+ SkDEBUGFAIL("Invalid flag type");
}
return result;
}
@@ -379,7 +379,7 @@ public:
case SkFlagInfo::kDouble_FlagType:
return SkString("double");
default:
- SkASSERT(!"Invalid flag type");
+ SkDEBUGFAIL("Invalid flag type");
return SkString();
}
}
« no previous file with comments | « tests/PathTest.cpp ('k') | tools/flags/SkCommandLineFlags.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698