Issue 22874003: Don't call computeSignature in the emitter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22874003: Don't call computeSignature in the emitter. (Closed)

Created:
7 years, 4 months ago by ngeoffray

Modified:
7 years, 4 months ago

Reviewers:
karlklose, ahe

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Don't call computeSignature in the emitter. R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=26176

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -4 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/elements/modelx.dart	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/resolution/members.dart	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

This is addressing comment: https://codereview.chromium.org/19754002/diff/2001/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart#newcode3420

7 years, 4 months ago (2013-08-15 08:22:56 UTC) #1

ngeoffray

7 years, 4 months ago (2013-08-15 09:24:42 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r26176 (presubmit successful).

Expand Messages | Collapse Messages