Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: sdk/lib/_internal/compiler/implementation/elements/modelx.dart

Issue 22874003: Don't call computeSignature in the emitter. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/elements/modelx.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/elements/modelx.dart (revision 26119)
+++ sdk/lib/_internal/compiler/implementation/elements/modelx.dart (working copy)
@@ -1419,16 +1419,17 @@
FunctionElement get targetConstructor => superMember;
FunctionSignature computeSignature(compiler) {
+ if (functionSignature != null) return functionSignature;
if (isDefaultConstructor) {
- return new FunctionSignatureX(
+ return functionSignature = new FunctionSignatureX(
const Link<Element>(), const Link<Element>(), 0, 0, false,
getEnclosingClass().thisType);
}
if (superMember.isErroneous()) {
- return compiler.objectClass.localLookup(
+ return functionSignature = compiler.objectClass.localLookup(
const SourceString('')).computeSignature(compiler);
}
- return superMember.computeSignature(compiler);
+ return functionSignature = superMember.computeSignature(compiler);
}
get declaration => this;
« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698