Rewrite how we handle synthesized constructors in the compiler. This was motivated by issue https:/…

sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of js_backend;
 
 /**
  * A function element that represents a closure call. The signature is copied
  * from the given element.
  */
@@ skipping 3399 matching lines @@
     return globalMetadataMap.putIfAbsent(string, () {
       globalMetadata.add(string);
       return globalMetadata.length - 1;
     });
   }
 
   jsAst.Fun extendWithMetadata(FunctionElement element, jsAst.Fun code) {
     if (!backend.retainMetadataOf(element)) return code;
     return compiler.withCurrentElement(element, () {
       List<int> metadata = <int>[];
-      FunctionSignature signature = element.functionSignature;
+      FunctionSignature signature = element.computeSignature(compiler);

[ahe, 2013/07/18 09:59:32]

Why this change?

[ngeoffray, 2013/07/18 15:25:14]

Apparently, it's not ensured that functionSignature is not null at this point.

[ahe, 2013/07/19 09:10:44]

That is a bug.  It must be non-null. Calling computeSignature can start
enqueueing stuff.

I think it would be best if you can ensure the resolver has computed the
signature already.

[ngeoffray, 2013/08/15 08:23:19]

Done in: https://codereview.chromium.org/22874003/

       if (element.isConstructor()) {
         metadata.add(reifyType(element.getEnclosingClass().thisType));
       } else {
         metadata.add(reifyType(signature.returnType));
       }
       signature.forEachParameter((Element parameter) {
         metadata
             ..add(reifyName(parameter.name))
             ..add(reifyType(parameter.computeType(compiler)));
       });
@@ skipping 456 matching lines @@
 
 const String HOOKS_API_USAGE = """
 // The code supports the following hooks:
 // dartPrint(message)   - if this function is defined it is called
 //                        instead of the Dart [print] method.
 // dartMainRunner(main) - if this function is defined, the Dart [main]
 //                        method will not be invoked directly.
 //                        Instead, a closure that will invoke [main] is
 //                        passed to [dartMainRunner].
 """;