device/bluetooth/bluetooth_remote_gatt_characteristic_mac.h - Issue 2287273002: Remove TODOs that are out of date.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/bluetooth/bluetooth_remote_gatt_characteristic_mac.h

Issue 2287273002: Remove TODOs that are out of date. (Closed)

Patch Set: Fix a compile error on mac Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: device/bluetooth/bluetooth_remote_gatt_characteristic_mac.h

diff --git a/device/bluetooth/bluetooth_remote_gatt_characteristic_mac.h b/device/bluetooth/bluetooth_remote_gatt_characteristic_mac.h

index 98316c77e7f6a16d3b450c651bc2bc1b4ff00464..3784a785fa1e5f859229f8e5e4a645f05f132d03 100644

--- a/device/bluetooth/bluetooth_remote_gatt_characteristic_mac.h

+++ b/device/bluetooth/bluetooth_remote_gatt_characteristic_mac.h

@@ -50,7 +50,7 @@ class DEVICE_BLUETOOTH_EXPORT BluetoothRemoteGattCharacteristicMac

const base::Closure& callback) override;

void ReadRemoteCharacteristic(const ValueCallback& callback,

const ErrorCallback& error_callback) override;

- void WriteRemoteCharacteristic(const std::vector<uint8_t>& new_value,

+ void WriteRemoteCharacteristic(const std::vector<uint8_t>& value,

const base::Closure& callback,

const ErrorCallback& error_callback) override;