Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3036)

Unified Diff: device/bluetooth/bluetooth_remote_gatt_characteristic_android.cc

Issue 2287273002: Remove TODOs that are out of date. (Closed)
Patch Set: Fix a compile error on mac Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/bluetooth/bluetooth_remote_gatt_characteristic_android.cc
diff --git a/device/bluetooth/bluetooth_remote_gatt_characteristic_android.cc b/device/bluetooth/bluetooth_remote_gatt_characteristic_android.cc
index 0e8cfd8d845fc67a3f063834938832e018522dea..594303773ae06602ff55644b2728cd34a7d0f7cc 100644
--- a/device/bluetooth/bluetooth_remote_gatt_characteristic_android.cc
+++ b/device/bluetooth/bluetooth_remote_gatt_characteristic_android.cc
@@ -141,7 +141,7 @@ void BluetoothRemoteGattCharacteristicAndroid::ReadRemoteCharacteristic(
}
void BluetoothRemoteGattCharacteristicAndroid::WriteRemoteCharacteristic(
- const std::vector<uint8_t>& new_value,
+ const std::vector<uint8_t>& value,
const base::Closure& callback,
const ErrorCallback& error_callback) {
if (read_pending_ || write_pending_) {
@@ -154,8 +154,7 @@ void BluetoothRemoteGattCharacteristicAndroid::WriteRemoteCharacteristic(
JNIEnv* env = AttachCurrentThread();
if (!Java_ChromeBluetoothRemoteGattCharacteristic_writeRemoteCharacteristic(
- env, j_characteristic_,
- base::android::ToJavaByteArray(env, new_value))) {
+ env, j_characteristic_, base::android::ToJavaByteArray(env, value))) {
base::ThreadTaskRunnerHandle::Get()->PostTask(
FROM_HERE, base::Bind(error_callback,
BluetoothRemoteGattService::GATT_ERROR_FAILED));
@@ -214,7 +213,6 @@ void BluetoothRemoteGattCharacteristicAndroid::OnWrite(
if (status == 0 // android.bluetooth.BluetoothGatt.GATT_SUCCESS
&& !write_callback.is_null()) {
write_callback.Run();
- // TODO(https://crbug.com/545682): Call GattCharacteristicValueChanged.
} else if (!write_error_callback.is_null()) {
write_error_callback.Run(
BluetoothRemoteGattServiceAndroid::GetGattErrorCode(status));

Powered by Google App Engine
This is Rietveld 408576698