Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Unified Diff: device/bluetooth/bluetooth_remote_gatt_characteristic_mac.mm

Issue 2287273002: Remove TODOs that are out of date. (Closed)
Patch Set: Fix a compile error on mac Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/bluetooth/bluetooth_remote_gatt_characteristic_mac.mm
diff --git a/device/bluetooth/bluetooth_remote_gatt_characteristic_mac.mm b/device/bluetooth/bluetooth_remote_gatt_characteristic_mac.mm
index 4e825a3c57b51b94d39fbc493e5a9a1b77adab54..ffa4ad601678c1ef63e5d64d42da5f7acea87141 100644
--- a/device/bluetooth/bluetooth_remote_gatt_characteristic_mac.mm
+++ b/device/bluetooth/bluetooth_remote_gatt_characteristic_mac.mm
@@ -198,7 +198,7 @@ void BluetoothRemoteGattCharacteristicMac::ReadRemoteCharacteristic(
}
void BluetoothRemoteGattCharacteristicMac::WriteRemoteCharacteristic(
- const std::vector<uint8_t>& new_value,
+ const std::vector<uint8_t>& value,
const base::Closure& callback,
const ErrorCallback& error_callback) {
if (!IsWritable()) {
@@ -219,7 +219,7 @@ void BluetoothRemoteGattCharacteristicMac::WriteRemoteCharacteristic(
write_characteristic_value_callbacks_ =
std::make_pair(callback, error_callback);
base::scoped_nsobject<NSData> nsdata_value(
- [[NSData alloc] initWithBytes:new_value.data() length:new_value.size()]);
+ [[NSData alloc] initWithBytes:value.data() length:value.size()]);
CBCharacteristicWriteType write_type = GetCBWriteType();
[gatt_service_->GetCBPeripheral() writeValue:nsdata_value
forCharacteristic:cb_characteristic_

Powered by Google App Engine
This is Rietveld 408576698