Issue 2285133003: Use .innerText in text-only mode

Issue 2285133003: Use .innerText in text-only mode (Closed)

Created:
4 years, 3 months ago by wychen

Modified:
4 years, 3 months ago

Reviewers:
mdjones

Base URL:
git@github.com:chromium/dom-distiller.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Use .innerText in text-only mode This only affects text-only mode used in internal evaluation. The behavior on prod doesn't change. The testing scores before this change were lower than it should've been. Score changes: https://x20web.corp.google.com/~wychen/domdistillerscore/innerText/knowledge.html Average F1: 0.960 → 0.962 https://x20web.corp.google.com/~wychen/domdistillerscore/innerText/multi-page.html Average F1: 0.573 → 0.575 https://x20web.corp.google.com/~wychen/domdistillerscore/innerText/page-links.html Average F1: 0.922 → 0.923 https://x20web.corp.google.com/~wychen/domdistillerscore/innerText/reader-golden.html Average F1: 0.956 → 0.956+ BUG=637170 R=mdjones@chromium.org Committed: 23830cf606aec46d1ab133d20091a7b483fc5a8d

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -8 lines)			Patch
M	java/org/chromium/distiller/webdocument/WebFigure.java	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	java/org/chromium/distiller/webdocument/WebText.java	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	javatests/org/chromium/distiller/EmbedExtractorTest.java	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	javatests/org/chromium/distiller/webdocument/WebTextTest.java	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Dependent Patchsets:

Total messages: 5 (2 generated)

wychen

4 years, 3 months ago (2016-08-29 21:01:33 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
23830cf606aec46d1ab133d20091a7b483fc5a8d (presubmit successful).