Rename DisplayItem::Type enum constants to Chromium style.

Rename DisplayItem::Type enum constants to Chromium style.

This CL renames constants in
third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h under
blink::DisplayItem::Type enum, so that the constants follow Chromium
naming style (i.e. kPageOverlay instead of PageOverlay).

This is done as a separate CL, because the automated, clang-based
renaming tool cannot handle names built via macro token concatenation
(and this macro feature is used heavily in
platform/graphics/paint/DisplayItem.h).

BUG=641033
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/690c132cbec6ad770573f9157105fc6a041abd52
Cr-Commit-Position: refs/heads/master@{#415471}

[Łukasz Anforowicz, 2016-08-26 18:35:36]

Description was changed from

==========
Rename DisplayItem::Type enum constants to Chromium style.

This CL renames constants in
third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h under
blink::DisplayItem::Type enum, so that the constants follow Chromium
naming style (i.e. kPageOverlay instead of PageOverlay).

This is done as a separate CL, because the automated, clang-based
renaming tool cannot handle names built via macro token concatenation
(and this macro feature is used heavily in
platform/graphics/paint/DisplayItem.h).

BUG=641033
==========

to

==========
Rename DisplayItem::Type enum constants to Chromium style.

This CL renames constants in
third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h under
blink::DisplayItem::Type enum, so that the constants follow Chromium
naming style (i.e. kPageOverlay instead of PageOverlay).

This is done as a separate CL, because the automated, clang-based
renaming tool cannot handle names built via macro token concatenation
(and this macro feature is used heavily in
platform/graphics/paint/DisplayItem.h).

BUG=641033
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Łukasz Anforowicz, 2016-08-26 18:36:05]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 18:37:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 18:41:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 18:41:53]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Łukasz Anforowicz, 2016-08-26 20:51:35]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 20:52:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 21:15:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 21:15:14]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Łukasz Anforowicz, 2016-08-26 21:34:18]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 21:34:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Łukasz Anforowicz, 2016-08-26 23:01:31]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 23:02:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 23:24:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 23:24:50]

Dry run: Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[Łukasz Anforowicz, 2016-08-29 20:45:35]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-29 21:25:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Łukasz Anforowicz, 2016-08-29 23:42:50]

lukasza@chromium.org changed reviewers:
+ dcheng@chromium.org

[Łukasz Anforowicz, 2016-08-29 23:42:51]

dcheng@, can you take a look please?

[commit-bot: I haz the power, 2016-08-30 03:41:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 03:41:21]

Dry run: This issue passed the CQ dry run.

[dcheng, 2016-08-30 06:01:58]

dcheng@chromium.org changed reviewers:
+ jbroman@chromium.org

[dcheng, 2016-08-30 06:01:59]

The code change LGTM, but I'd run it by someone on the paint team. +jbroman

[Łukasz Anforowicz, 2016-08-30 16:04:18]

jbroman@, can you take a look please?

[pdr., 2016-08-30 16:22:45]

On 2016/08/30 at 16:04:18, lukasza wrote:
> jbroman@, can you take a look please?

LGTM

(jbroman now works more on platform-y things)

[Łukasz Anforowicz, 2016-08-30 16:28:33]

On 2016/08/30 16:22:45, pdr. wrote:
> On 2016/08/30 at 16:04:18, lukasza wrote:
> > jbroman@, can you take a look please?
> 
> LGTM
> 
Great - thanks for reviewing.

> (jbroman now works more on platform-y things)

Ack.

[Łukasz Anforowicz, 2016-08-30 16:28:44]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2016-08-30 16:29:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 16:35:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 16:35:55]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Łukasz Anforowicz, 2016-08-30 18:34:07]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 18:34:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Łukasz Anforowicz, 2016-08-30 20:51:43]

The CQ bit was unchecked by lukasza@chromium.org

[Łukasz Anforowicz, 2016-08-30 20:51:44]

The CQ bit was checked by lukasza@chromium.org

[Łukasz Anforowicz, 2016-08-30 20:51:45]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org,
dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2286843002/#ps90001
(title: "Rebasing...")

[commit-bot: I haz the power, 2016-08-30 20:52:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 22:46:02]

Committed patchset #6 (id:90001)

[commit-bot: I haz the power, 2016-08-30 22:49:28]

Description was changed from

==========
Rename DisplayItem::Type enum constants to Chromium style.

This CL renames constants in
third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h under
blink::DisplayItem::Type enum, so that the constants follow Chromium
naming style (i.e. kPageOverlay instead of PageOverlay).

This is done as a separate CL, because the automated, clang-based
renaming tool cannot handle names built via macro token concatenation
(and this macro feature is used heavily in
platform/graphics/paint/DisplayItem.h).

BUG=641033
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Rename DisplayItem::Type enum constants to Chromium style.

This CL renames constants in
third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h under
blink::DisplayItem::Type enum, so that the constants follow Chromium
naming style (i.e. kPageOverlay instead of PageOverlay).

This is done as a separate CL, because the automated, clang-based
renaming tool cannot handle names built via macro token concatenation
(and this macro feature is used heavily in
platform/graphics/paint/DisplayItem.h).

BUG=641033
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/690c132cbec6ad770573f9157105fc6a041abd52
Cr-Commit-Position: refs/heads/master@{#415471}
==========

[commit-bot: I haz the power, 2016-08-30 22:49:30]

Patchset 6 (id:??) landed as
https://crrev.com/690c132cbec6ad770573f9157105fc6a041abd52
Cr-Commit-Position: refs/heads/master@{#415471}