third_party/WebKit/Source/core/paint/TableCellPainter.cpp - Issue 2286843002: Rename DisplayItem::Type enum constants to Chromium style.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/TableCellPainter.cpp

Issue 2286843002: Rename DisplayItem::Type enum constants to Chromium style. (Closed)

Patch Set: Rebasing... Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/paint/ScrollableAreaPainter.cpp ('k') | third_party/WebKit/Source/core/paint/TableCellPainterTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/TableCellPainter.cpp

diff --git a/third_party/WebKit/Source/core/paint/TableCellPainter.cpp b/third_party/WebKit/Source/core/paint/TableCellPainter.cpp

index 4c81c5eb40e521293d5fca3ec1f87c38c24d9534..0aa28e15f34b871ca54fcc9d3549139636ddbbfc 100644

--- a/third_party/WebKit/Source/core/paint/TableCellPainter.cpp

+++ b/third_party/WebKit/Source/core/paint/TableCellPainter.cpp

@@ -75,7 +75,7 @@ void TableCellPainter::paintCollapsedBorders(const PaintInfo& paintInfo, const L

const CollapsedBorderValue& topBorderValue = collapsedTopBorder(styleForCellFlow, *values);

const CollapsedBorderValue& bottomBorderValue = collapsedBottomBorder(styleForCellFlow, *values);

- int displayItemType = DisplayItem::TableCollapsedBorderBase;

+ int displayItemType = DisplayItem::kTableCollapsedBorderBase;

if (topBorderValue.shouldPaint(currentBorderValue))

displayItemType |= DisplayItem::TableCollapsedBorderTop;

if (bottomBorderValue.shouldPaint(currentBorderValue))

@@ -84,7 +84,7 @@ void TableCellPainter::paintCollapsedBorders(const PaintInfo& paintInfo, const L

displayItemType |= DisplayItem::TableCollapsedBorderLeft;

if (rightBorderValue.shouldPaint(currentBorderValue))

displayItemType |= DisplayItem::TableCollapsedBorderRight;

- if (displayItemType == DisplayItem::TableCollapsedBorderBase)

+ if (displayItemType == DisplayItem::kTableCollapsedBorderBase)

return;

int topWidth = topBorderValue.width();

@@ -180,13 +180,13 @@ void TableCellPainter::paintBoxDecorationBackground(const PaintInfo& paintInfo,

if (!m_layoutTableCell.styleRef().hasBackground() && !m_layoutTableCell.styleRef().boxShadow() && !needsToPaintBorder)

return;

- if (LayoutObjectDrawingRecorder::useCachedDrawingIfPossible(paintInfo.context, m_layoutTableCell, DisplayItem::BoxDecorationBackground))

+ if (LayoutObjectDrawingRecorder::useCachedDrawingIfPossible(paintInfo.context, m_layoutTableCell, DisplayItem::kBoxDecorationBackground))

return;

LayoutRect visualOverflowRect = m_layoutTableCell.visualOverflowRect();

visualOverflowRect.moveBy(paintOffset);

// TODO(chrishtr): the pixel-snapping here is likely incorrect.

- LayoutObjectDrawingRecorder recorder(paintInfo.context, m_layoutTableCell, DisplayItem::BoxDecorationBackground, pixelSnappedIntRect(visualOverflowRect));

+ LayoutObjectDrawingRecorder recorder(paintInfo.context, m_layoutTableCell, DisplayItem::kBoxDecorationBackground, pixelSnappedIntRect(visualOverflowRect));

LayoutRect paintRect = paintRectNotIncludingVisualOverflow(paintOffset);