Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2286793003: Remove all references to GIT_MODE from depot_tools (Closed)

Created:
4 years, 3 months ago by agable
Modified:
4 years, 3 months ago
Reviewers:
martiniss
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix commit position #

Patch Set 3 : Slightly cleaner #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -218 lines) Patch
M recipe_modules/bot_update/api.py View 1 2 2 chunks +1 line, -9 lines 0 comments Download
M recipe_modules/bot_update/example.py View 1 2 2 chunks +2 lines, -8 lines 0 comments Download
M recipe_modules/bot_update/example.expected/basic.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/basic_output_manifest.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/basic_with_branch_heads.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/clobber.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/forced.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/gerrit_no_reset.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/gerrit_rebase_patch_ref.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/no_shallow.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/off.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/reset_root_solution_revision.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/svn_mode.json View 1 2 1 chunk +0 lines, -59 lines 0 comments Download
M recipe_modules/bot_update/example.expected/trychange.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/trychange_oauth2.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob_fail.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob_fail_patch.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob_fail_patch_download.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob_gerrit_angle.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob_v8.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/example.expected/tryjob_v8_head_by_default.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/bot_update/test_api.py View 1 4 chunks +13 lines, -18 lines 0 comments Download
M recipe_modules/gclient/api.py View 2 chunks +33 lines, -52 lines 0 comments Download
M recipe_modules/gclient/config.py View 11 chunks +15 lines, -43 lines 0 comments Download
M recipe_modules/gclient/example.py View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/gclient/test_api.py View 2 chunks +4 lines, -9 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 20 (14 generated)
agable
This doesn't roll quite perfectly into build/, but the diff is very small and is ...
4 years, 3 months ago (2016-08-26 20:46:15 UTC) #8
agable
Nevermind, with https://codereview.chromium.org/2280153003 this will roll cleanly.
4 years, 3 months ago (2016-08-26 21:01:49 UTC) #12
agable
On 2016/08/26 at 21:01:49, agable wrote: > Nevermind, with https://codereview.chromium.org/2280153003 this will roll cleanly. Yep, ...
4 years, 3 months ago (2016-08-26 21:43:12 UTC) #15
martiniss
lgtm
4 years, 3 months ago (2016-08-26 21:48:23 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2286793003/40001
4 years, 3 months ago (2016-08-26 21:58:05 UTC) #18
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 22:04:45 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/7090f652d180ee...

Powered by Google App Engine
This is Rietveld 408576698