Remove all references to GIT_MODE from depot_tools

recipe_modules/gclient/config.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import types
 
 from recipe_engine.config import config_item_context, ConfigGroup, BadConf
 from recipe_engine.config import ConfigList, Dict, Single, Static, Set, List
 
 from . import api as gclient_api
 
 
-def BaseConfig(USE_MIRROR=True, GIT_MODE=True, CACHE_DIR=None,
+def BaseConfig(USE_MIRROR=True, CACHE_DIR=None,
                PATCH_PROJECT=None, BUILDSPEC_VERSION=None,
                **_kwargs):
-  deps = '.DEPS.git' if GIT_MODE else 'DEPS'
   cache_dir = str(CACHE_DIR) if CACHE_DIR else None
   return ConfigGroup(
     solutions = ConfigList(
       lambda: ConfigGroup(
         name = Single(basestring),
         url = Single(basestring),
-        deps_file = Single(basestring, empty_val=deps, required=False,
+        deps_file = Single(basestring, empty_val='.DEPS.git', required=False,
                            hidden=False),
         managed = Single(bool, empty_val=True, required=False, hidden=False),
         custom_deps = Dict(value_type=(basestring, types.NoneType)),
         custom_vars = Dict(value_type=basestring),
         safesync_url = Single(basestring, required=False),
 
         revision = Single(
             (basestring, gclient_api.RevisionResolver),
             required=False, hidden=True),
       )
@@ skipping 45 matching lines @@
     patch_projects = Dict(value_type=tuple, hidden=True),
 
     # Check out refs/branch-heads.
     # TODO (machenbach): Only implemented for bot_update atm.
     with_branch_heads = Single(
         bool,
         empty_val=False,
         required=False,
         hidden=True),
 
-    GIT_MODE = Static(bool(GIT_MODE)),
     USE_MIRROR = Static(bool(USE_MIRROR)),
     # TODO(tandrii): remove PATCH_PROJECT field.
     # DON'T USE THIS. WILL BE REMOVED.
     PATCH_PROJECT = Static(str(PATCH_PROJECT), hidden=True),
     BUILDSPEC_VERSION= Static(BUILDSPEC_VERSION, hidden=True),
   )
 
 config_ctx = config_item_context(BaseConfig)
 
 def ChromiumSvnSubURL(c, *pieces):  # pragma: no cover
   BASES = ('https://src.chromium.org',
            'svn://svn-mirror.golo.chromium.org')
   return '/'.join((BASES[c.USE_MIRROR],) + pieces)
 
 def ChromiumGitURL(_c, *pieces):
   return '/'.join(('https://chromium.googlesource.com',) + pieces)
 
 def ChromiumSrcURL(c):
-  # TODO(phajdan.jr): Move to proper repo and add coverage.
-  if c.GIT_MODE:
-    return ChromiumGitURL(c, 'chromium', 'src.git')
-  else:  # pragma: no cover
-    return ChromiumSvnSubURL(c, 'chrome', 'trunk', 'src')
+  return ChromiumGitURL(c, 'chromium', 'src.git')
 
 def BlinkURL(c):
-  # TODO(phajdan.jr): Move to proper repo and add coverage.
-  if c.GIT_MODE:
-    return ChromiumGitURL(c, 'chromium', 'blink.git')
-  else:  # pragma: no cover
-    return ChromiumSvnSubURL(c, 'blink', 'trunk')
+  return ChromiumGitURL(c, 'chromium', 'blink.git')
 
 def ChromeSvnSubURL(c, *pieces):  # pragma: no cover
   BASES = ('svn://svn.chromium.org',
            'svn://svn-mirror.golo.chromium.org')
   return '/'.join((BASES[c.USE_MIRROR],) + pieces)
 
 # TODO(phajdan.jr): Move to proper repo and add coverage.
 def ChromeInternalGitURL(_c, *pieces):  # pragma: no cover
   return '/'.join(('https://chrome-internal.googlesource.com',) + pieces)
 
 def ChromeInternalSrcURL(c):
-  # TODO(phajdan.jr): Move to proper repo and add coverage.
-  if c.GIT_MODE:
-    return ChromeInternalGitURL(c, 'chrome', 'src-internal.git')
-  else:  # pragma: no cover
-    return ChromeSvnSubURL(c, 'chrome-internal', 'trunk', 'src-internal')
+  return ChromeInternalGitURL(c, 'chrome', 'src-internal.git')
 
 def mirror_only(c, obj, default=None):
   return obj if c.USE_MIRROR else (default or obj.__class__())
 
 @config_ctx()
 def chromium_bare(c):
   s = c.solutions.add()
   s.name = 'src'
   s.url = ChromiumSrcURL(c)
   s.custom_vars = mirror_only(c, {
@@ skipping 124 matching lines @@
   # and there's no gclient fallback, then the following line can be removed.
   c.solutions[0].custom_vars['v8_branch'] = 'branches/bleeding_edge'
   c.revisions['src/v8'] = 'HEAD'
 
 @config_ctx()
 def v8_canary(c):
   c.revisions['src/v8'] = 'origin/canary'
 
 @config_ctx(includes=['chromium'])
 def oilpan(c):  # pragma: no cover
-  if c.GIT_MODE:
-    raise BadConf("Oilpan requires SVN for now")
   c.solutions[0].custom_vars = {
     'webkit_trunk': ChromiumSvnSubURL(c, 'blink', 'branches', 'oilpan')
   }
   c.solutions[0].custom_vars['sourceforge_url'] = mirror_only(
     c,
     'svn://svn-mirror.golo.chromium.org/%(repo)s',
     'svn://svn.chromium.org/%(repo)s'
   )
 
   c.revisions['src/third_party/WebKit'] = 'HEAD'
@@ skipping 50 matching lines @@
   c.revisions['src'] = 'origin/master'
 
 @config_ctx()
 def gyp(c):
   s = c.solutions.add()
   s.name = 'gyp'
   s.url = ChromiumGitURL(c, 'external', 'gyp.git')
   m = c.got_revision_mapping
   m['gyp'] = 'got_revision'
 
-@config_ctx(config_vars={'GIT_MODE': True})
+@config_ctx()
 def build(c):
-  if not c.GIT_MODE:  # pragma: no cover
-    raise BadConf('build only supports git')
   s = c.solutions.add()
   s.name = 'build'
   s.url = ChromiumGitURL(c, 'chromium', 'tools', 'build.git')
   m = c.got_revision_mapping
   m['build'] = 'got_revision'
 
-@config_ctx(config_vars={'GIT_MODE': True})
+@config_ctx()
 def depot_tools(c):  # pragma: no cover
-  if not c.GIT_MODE:
-    raise BadConf('depot_tools only supports git')
   s = c.solutions.add()
   s.name = 'depot_tools'
   s.url = ChromiumGitURL(c, 'chromium', 'tools', 'depot_tools.git')
   m = c.got_revision_mapping
   m['depot_tools'] = 'got_revision'
 
-@config_ctx(config_vars={'GIT_MODE': True})
+@config_ctx()
 def skia(c):  # pragma: no cover
-  if not c.GIT_MODE:
-    raise BadConf('skia only supports git')
   s = c.solutions.add()
   s.name = 'skia'
   s.url = 'https://skia.googlesource.com/skia.git'
   m = c.got_revision_mapping
   m['skia'] = 'got_revision'
 
-@config_ctx(config_vars={'GIT_MODE': True})
+@config_ctx()
 def chrome_golo(c):  # pragma: no cover
-  if not c.GIT_MODE:
-    raise BadConf('chrome_golo only supports git')
   s = c.solutions.add()
   s.name = 'chrome_golo'
   s.url = 'https://chrome-internal.googlesource.com/chrome-golo/chrome-golo.git'
   c.got_revision_mapping['chrome_golo'] = 'got_revision'
 
-@config_ctx(config_vars={'GIT_MODE': True})
+@config_ctx()
 def build_internal(c):
-  if not c.GIT_MODE:  # pragma: no cover
-    raise BadConf('build_internal only supports git')
   s = c.solutions.add()
   s.name = 'build_internal'
   s.url = 'https://chrome-internal.googlesource.com/chrome/tools/build.git'
   c.got_revision_mapping['build_internal'] = 'got_revision'
   # We do not use 'includes' here, because we want build_internal to be the
   # first solution in the list as run_presubmit computes upstream revision
   # from the first solution.
   build(c)
   c.got_revision_mapping['build'] = 'got_build_revision'
 
-@config_ctx(config_vars={'GIT_MODE': True})
+@config_ctx()
 def build_internal_scripts_slave(c):
-  if not c.GIT_MODE:  # pragma: no cover
-    raise BadConf('build_internal_scripts_slave only supports git')
   s = c.solutions.add()
   s.name = 'build_internal/scripts/slave'
   s.url = ('https://chrome-internal.googlesource.com/'
            'chrome/tools/build_limited/scripts/slave.git')
   c.got_revision_mapping['build_internal/scripts/slave'] = 'got_revision'
   # We do not use 'includes' here, because we want build_internal to be the
   # first solution in the list as run_presubmit computes upstream revision
   # from the first solution.
   build(c)
   c.got_revision_mapping['build'] = 'got_build_revision'
@@ skipping 110 matching lines @@
 
 @config_ctx()
 def dart(c):
   soln = c.solutions.add()
   soln.name = 'sdk'
   soln.url = ('https://chromium.googlesource.com/external/github.com/' +
               'dart-lang/sdk.git')
   soln.deps_file = 'DEPS'
   soln.managed = False
 
-@config_ctx(config_vars={'GIT_MODE': True})
+@config_ctx()
 def infra(c):
   soln = c.solutions.add()
   soln.name = 'infra'
   soln.url = 'https://chromium.googlesource.com/infra/infra.git'
   c.got_revision_mapping['infra'] = 'got_revision'
 
   p = c.patch_projects
   p['luci-py'] = ('infra/luci', 'HEAD')
   # TODO(phajdan.jr): remove recipes-py when it's not used for project name.
   p['recipes-py'] = ('infra/recipes-py', 'HEAD')
   p['recipe_engine'] = ('infra/recipes-py', 'HEAD')
 
-@config_ctx(config_vars={'GIT_MODE': True})
+@config_ctx()
 def infra_internal(c):  # pragma: no cover
   soln = c.solutions.add()
   soln.name = 'infra_internal'
   soln.url = 'https://chrome-internal.googlesource.com/infra/infra_internal.git'
   c.got_revision_mapping['infra_internal'] = 'got_revision'
 
 @config_ctx(includes=['infra'])
 def luci_gae(c):
   # luci/gae is checked out as a part of infra.git solution at HEAD.
   c.revisions['infra'] = 'origin/master'
@@ skipping 30 matching lines @@
 @config_ctx(includes=['infra'])
 def recipes_py(c):
   c.revisions['infra'] = 'origin/master'
   # TODO(tandrii): make use of c.patch_projects.
   c.revisions['infra/recipes-py'] = (
       gclient_api.RevisionFallbackChain('origin/master'))
   m = c.got_revision_mapping
   del m['infra']
   m['infra/recipes-py'] = 'got_revision'
 
-@config_ctx(config_vars={'GIT_MODE': True})
+@config_ctx()
 def recipes_py_bare(c):
   soln = c.solutions.add()
   soln.name = 'recipes-py'
   soln.url = ('https://chromium.googlesource.com/external/github.com/'
               'luci/recipes-py')
   c.got_revision_mapping['recipes-py'] = 'got_revision'
 
 @config_ctx()
 def chrome_from_buildspec(c):  # pragma: no cover
   soln = c.solutions.add()
   soln.name = 'chrome_from_buildspec'
   # This URL has to be augmented with the appropriate bucket by the recipe using
   # it.
   soln.url = ('svn://svn-mirror.golo.chromium.org/chrome-internal/trunk/tools/'
       'buildspec/build/')
   soln.custom_vars['svn_url'] = 'svn://svn-mirror.golo.chromium.org'
   soln.custom_deps = {}
 
 @config_ctx()
 def catapult(c):
   soln = c.solutions.add()
   soln.name = 'catapult'
   soln.url = ('https://chromium.googlesource.com/external/github.com/'
               'catapult-project/catapult.git')
   c.got_revision_mapping['catapult'] = 'got_revision'
 
-@config_ctx(includes=['infra_internal'], config_vars={'GIT_MODE': True})
+@config_ctx(includes=['infra_internal'])
 def infradata_master_manager(c):
   soln = c.solutions.add()
   soln.name = 'infra-data-master-manager'
   soln.url = (
       'https://chrome-internal.googlesource.com/infradata/master-manager.git')
   c.got_revision_mapping['infra-data-master-manager'] = 'got_revision'
 
 @config_ctx()
 def with_branch_heads(c):
   c.with_branch_heads = True
@@ skipping 30 matching lines @@
   """Add Valgrind binaries to the gclient solution."""
   c.solutions[0].custom_deps['src/third_party/valgrind'] = \
     ChromiumGitURL(c, 'chromium', 'deps', 'valgrind', 'binaries')
 
 @config_ctx(includes=['chromium'])
 def chromedriver(c):
   """Add Selenium Java tests to the gclient solution."""
   c.solutions[0].custom_deps[
       'src/chrome/test/chromedriver/third_party/java_tests'] = (
           ChromiumGitURL(c, 'chromium', 'deps', 'webdriver'))