Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2280153003: Remove svn test from run_presubmit recipe module (Closed)

Created:
4 years, 3 months ago by agable
Modified:
4 years, 3 months ago
Reviewers:
iannucci, hinoka
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -197 lines) Patch
M scripts/slave/recipes/run_presubmit.py View 2 chunks +0 lines, -17 lines 0 comments Download
D scripts/slave/recipes/run_presubmit.expected/fake_svn_master.json View 1 chunk +0 lines, -180 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
agable
4 years, 3 months ago (2016-08-26 21:01:28 UTC) #1
hinoka
lgtm
4 years, 3 months ago (2016-08-26 21:03:38 UTC) #4
iannucci
On 2016/08/26 at 21:03:38, hinoka wrote: > lgtm change lgtm, but tryjob looks like flake.
4 years, 3 months ago (2016-08-26 21:22:59 UTC) #7
agable
On 2016/08/26 at 21:22:59, iannucci wrote: > On 2016/08/26 at 21:03:38, hinoka wrote: > > ...
4 years, 3 months ago (2016-08-26 21:26:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2280153003/1
4 years, 3 months ago (2016-08-26 21:26:41 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 21:30:58 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/26635e19ea94362a07e3...

Powered by Google App Engine
This is Rietveld 408576698