Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2286503002: Converted Observatory error-view element (Closed)

Created:
4 years, 3 months ago by cbernaschina
Modified:
4 years, 3 months ago
Reviewers:
turnidge, rmacnak, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+389 lines, -335 lines) Patch
M runtime/observatory/lib/elements.dart View 4 chunks +3 lines, -1 line 0 comments Download
M runtime/observatory/lib/elements.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/app/page.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/error_view.dart View 1 chunk +87 lines, -8 lines 1 comment Download
D runtime/observatory/lib/src/elements/error_view.html View 1 chunk +0 lines, -19 lines 0 comments Download
M runtime/observatory/lib/src/elements/instance_view.html View 2 chunks +281 lines, -288 lines 2 comments Download
M runtime/observatory/lib/src/elements/megamorphiccache_view.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/object_view.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/objectpool_view.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/service_view.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/elements/service_view.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/observatory_sources.gypi View 1 chunk +0 lines, -1 line 0 comments Download
A + runtime/observatory/tests/observatory_ui/error_view/element_test.dart View 1 chunk +7 lines, -8 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/error_view/element_test.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/error.dart View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
cbernaschina
4 years, 3 months ago (2016-08-25 23:13:36 UTC) #2
rmacnak
lgtm https://chromiumcodereview.appspot.com/2286503002/diff/1/runtime/observatory/lib/src/elements/error_view.dart File runtime/observatory/lib/src/elements/error_view.dart (right): https://chromiumcodereview.appspot.com/2286503002/diff/1/runtime/observatory/lib/src/elements/error_view.dart#newcode94 runtime/observatory/lib/src/elements/error_view.dart:94: throw new Exception('Unkown M.ErrorKind ($kind)'); unknown https://chromiumcodereview.appspot.com/2286503002/diff/1/runtime/observatory/lib/src/elements/instance_view.html File ...
4 years, 3 months ago (2016-08-26 17:05:26 UTC) #3
cbernaschina
4 years, 3 months ago (2016-08-26 17:23:41 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2dbd1b2158932d9bfde96c4e1530fb6a863ba3f0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698