Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/observatory/lib/src/app/page.dart

Issue 2286503002: Converted Observatory error-view element (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/lib/elements.html ('k') | runtime/observatory/lib/src/elements/error_view.dart » ('j') | runtime/observatory/lib/src/elements/error_view.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/src/app/page.dart
diff --git a/runtime/observatory/lib/src/app/page.dart b/runtime/observatory/lib/src/app/page.dart
index bad6c88d2d1d65ebc7b34433f7db8926e868ee76..cb1e264d92a4e08e9aa2d4a4aba5edc3cd1b69d6 100644
--- a/runtime/observatory/lib/src/app/page.dart
+++ b/runtime/observatory/lib/src/app/page.dart
@@ -194,6 +194,10 @@ class InspectPage extends MatchingPage {
_instanceRepository,
queue: app.queue)
];
+ } else if (obj is DartError) {
+ container.children = [
+ new ErrorViewElement(app.notifications, obj, queue: app.queue)
+ ];
} else if (obj is ICData) {
container.children = [
new ICDataViewElement(app.vm, obj.isolate, obj, app.events,
« no previous file with comments | « runtime/observatory/lib/elements.html ('k') | runtime/observatory/lib/src/elements/error_view.dart » ('j') | runtime/observatory/lib/src/elements/error_view.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698