Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Unified Diff: runtime/observatory/tests/observatory_ui/error_view/element_test.dart

Issue 2286503002: Converted Observatory error-view element (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/tests/observatory_ui/error_view/element_test.dart
diff --git a/runtime/observatory/tests/observatory_ui/class_ref/element_test.dart b/runtime/observatory/tests/observatory_ui/error_view/element_test.dart
similarity index 66%
copy from runtime/observatory/tests/observatory_ui/class_ref/element_test.dart
copy to runtime/observatory/tests/observatory_ui/error_view/element_test.dart
index 41aeb10f3d6ae1904271442cb5ec399cdc196e0f..7d30a03c82ae417cbe25c405b6fbb589b16b1518 100644
--- a/runtime/observatory/tests/observatory_ui/class_ref/element_test.dart
+++ b/runtime/observatory/tests/observatory_ui/error_view/element_test.dart
@@ -4,22 +4,21 @@
import 'dart:html';
import 'package:unittest/unittest.dart';
-import 'package:observatory/src/elements/class_ref.dart';
+import 'package:observatory/src/elements/error_view.dart';
import '../mocks.dart';
main() {
- ClassRefElement.tag.ensureRegistration();
+ ErrorViewElement.tag.ensureRegistration();
- const isolate = const IsolateRefMock();
- const cls = const ClassRefMock();
+ final notifs = new NotificationRepositoryMock();
+ final error = const ErrorMock();
test('instantiation', () {
- final e = new ClassRefElement(isolate, cls);
+ final e = new ErrorViewElement(notifs, error);
expect(e, isNotNull, reason: 'element correctly created');
- expect(e.isolate, equals(isolate));
- expect(e.cls, equals(cls));
+ expect(e.error, equals(error));
});
test('elements created after attachment', () async {
- final e = new ClassRefElement(isolate, cls);
+ final e = new ErrorViewElement(notifs, error);
document.body.append(e);
await e.onRendered.first;
expect(e.children.length, isNonZero, reason: 'has elements');

Powered by Google App Engine
This is Rietveld 408576698