Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 228633003: Do not dispatch change event when pressing spin button for input type=datetime (Closed)

Created:
6 years, 8 months ago by Habib Virji
Modified:
6 years, 8 months ago
Reviewers:
tkent, keishi1
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Do not dispatch change event when pressing spin button for input type=datetime Date time dispatches change event only on mouseUp. On mouseDown only input event is triggered. Changes in this CL are to incorporate keyboard press and picker selection. Change event trigger for mouseDown and mouseUp relies on CL#196933006. R=tkent@chromium.org,keishi1@chromium.org BUG=155747 TEST=Test on mouseDown only input event is triggered and on mouseUp only change event is triggered. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171217

Patch Set 1 #

Patch Set 2 : Detach handling for DateTime field #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -2 lines) Patch
M LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-spinbutton-change-and-input-events-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M LayoutTests/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-spinbutton-change-and-input-events-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-spinbutton-change-and-input-events-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M LayoutTests/fast/forms/number/number-spinbutton-change-and-input-events-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M LayoutTests/fast/forms/resources/common-spinbutton-change-and-input-events.js View 1 chunk +5 lines, -0 lines 0 comments Download
M LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-spinbutton-change-and-input-events-expected.txt View 1 1 chunk +5 lines, -0 lines 0 comments Download
M LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-spinbutton-change-and-input-events-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp View 1 4 chunks +8 lines, -1 line 0 comments Download
M Source/core/html/shadow/DateTimeEditElement.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/html/shadow/DateTimeEditElement.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/html/shadow/DateTimeFieldElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/shadow/DateTimeFieldElement.cpp View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Habib Virji
Relanding of previously submitted patch for not to dispatch change event for date time. This ...
6 years, 8 months ago (2014-04-08 14:19:52 UTC) #1
tkent
Similar to the type=number case, we need to call SpinButtonElement::releaseCapture in BaseMultipleFieldsDateAndTimeInputType::didBlurFromControl because we remove ...
6 years, 8 months ago (2014-04-09 00:32:53 UTC) #2
Habib Virji
On 2014/04/09 00:32:53, tkent wrote: > Similar to the type=number case, we need to call ...
6 years, 8 months ago (2014-04-09 08:17:37 UTC) #3
tkent
lgtm
6 years, 8 months ago (2014-04-10 01:07:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/habib.virji@samsung.com/228633003/20001
6 years, 8 months ago (2014-04-10 01:07:11 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-10 01:55:17 UTC) #6
Message was sent while issue was closed.
Change committed as 171217

Powered by Google App Engine
This is Rietveld 408576698