Source/core/html/shadow/DateTimeEditElement.h - Issue 228633003: Do not dispatch change event when pressing spin button for input type=datetime

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/shadow/DateTimeEditElement.h

Issue 228633003: Do not dispatch change event when pressing spin button for input type=datetime (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Detach handling for DateTime field Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp ('k') | Source/core/html/shadow/DateTimeEditElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/shadow/DateTimeEditElement.h

diff --git a/Source/core/html/shadow/DateTimeEditElement.h b/Source/core/html/shadow/DateTimeEditElement.h

index ede87640006d533ed55eee892b57f633198b8842..eb2c0a6e59c93bb1bdd1e3030c0ab211271c26b1 100644

--- a/Source/core/html/shadow/DateTimeEditElement.h

+++ b/Source/core/html/shadow/DateTimeEditElement.h

@@ -59,6 +59,7 @@ public:

virtual bool isEditControlOwnerDisabled() const = 0;

virtual bool isEditControlOwnerReadOnly() const = 0;

virtual AtomicString localeIdentifier() const = 0;

+ virtual void editControlDidChangeValueByKeyboard() = 0;

};

struct LayoutParameters {

@@ -144,6 +145,7 @@ private:

virtual bool isFieldOwnerDisabled() const OVERRIDE;

virtual bool isFieldOwnerReadOnly() const OVERRIDE;

virtual AtomicString localeIdentifier() const OVERRIDE;

+ virtual void fieldDidChangeValueByKeyboard() OVERRIDE;

Vector<DateTimeFieldElement*, maximumNumberOfFields> m_fields;

EditControlOwner* m_editControlOwner;