LayoutTests/fast/forms/resources/common-spinbutton-change-and-input-events.js - Issue 228633003: Do not dispatch change event when pressing spin button for input type=datetime

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/forms/resources/common-spinbutton-change-and-input-events.js

Issue 228633003: Do not dispatch change event when pressing spin button for input type=datetime (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Detach handling for DateTime field Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/forms/number/number-spinbutton-change-and-input-events-expected.txt ('k') | LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-spinbutton-change-and-input-events-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/forms/resources/common-spinbutton-change-and-input-events.js

diff --git a/LayoutTests/fast/forms/resources/common-spinbutton-change-and-input-events.js b/LayoutTests/fast/forms/resources/common-spinbutton-change-and-input-events.js

index 83376284b515ec52c89dd8520b29b9a0bb5d860e..ad704dab940268a440a13c26d4351ba34257fe45 100644

--- a/LayoutTests/fast/forms/resources/common-spinbutton-change-and-input-events.js

+++ b/LayoutTests/fast/forms/resources/common-spinbutton-change-and-input-events.js

@@ -34,6 +34,11 @@ function testSpinButtonChangeAndInputEvents(inputType, initialValue, expectedVal

var spinButton = getElementByPseudoId(internals.oldestShadowRoot(testInput), "-webkit-inner-spin-button");

eventSender.mouseMoveTo(testInput.offsetLeft + spinButton.offsetLeft, testInput.offsetTop + testInput.offsetHeight / 4);

eventSender.mouseDown();

+ debug('Triggers only input event on mouseDown');

+ shouldBeEqualToString('testInput.value', expectedValue);

+ shouldEvaluateTo('changeEventCounter', 0);

+ shouldEvaluateTo('inputEventCounter', 1);

+ debug('Triggers only change event on mouseUp');

eventSender.mouseUp();

shouldBeEqualToString('testInput.value', expectedValue);

shouldEvaluateTo('changeEventCounter', 1);