Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 2286003002: Reland of Check that all shared workers are terminated. (Closed)

Created:
4 years, 3 months ago by horo
Modified:
4 years, 3 months ago
CC:
chromium-reviews, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org, DaleCurtis, tommi (sloooow) - chröme
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Check that all shared workers are terminated. (patchset #2 id:170001 of https://codereview.chromium.org/2254963002/ ) Reason for revert: Shared Worker bug fix patch landed. https://codereview.chromium.org/2249173003/ BUG=639193 Original issue's description: > Revert of Check that all shared workers are terminated. (patchset #1 id:1 of https://codereview.chromium.org/2222063002/ ) > > Reason for revert: > Reverting temporary instrumentation following investigation > > We want to get this in prior to dev branch. > > BUG=636377 > > Original issue's description: > > Check that all shared workers are terminated. > > > > Adds temporary checks to determine whether shared workers > > prevent RenderProcessHost(s) from cleaning up due to > > RenderProcessHostImpl::worker_ref_count_ > 0. > > > > BUG=608049 > > > > Committed: https://crrev.com/529173d1bbeb53b3f9438648fad264b4db042721 > > Cr-Commit-Position: refs/heads/master@{#410730} > > TBR=atwilson@chromium.org,jam@chromium.org,horo@chromium.org,alokp@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=608049 > > Committed: https://crrev.com/463ac7e96bf55b106225481811b0db752284bbed > Cr-Commit-Position: refs/heads/master@{#412660} TBR=atwilson@chromium.org,jam@chromium.org,alokp@chromium.org,erikchen@chromium.org,manzagop@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=636377 Committed: https://crrev.com/d1109b15f8669b2c342d87e9ae6e5d8ebd669ada Cr-Commit-Position: refs/heads/master@{#414952}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -0 lines) Patch
M content/browser/browser_main_loop.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M content/browser/browser_process_sub_thread.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.h View 1 chunk +6 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M content/browser/shared_worker/shared_worker_service_impl.h View 1 chunk +6 lines, -0 lines 0 comments Download
M content/browser/shared_worker/shared_worker_service_impl.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
horo
Created Reland of Check that all shared workers are terminated.
4 years, 3 months ago (2016-08-27 00:57:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2286003002/1
4 years, 3 months ago (2016-08-27 00:58:53 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/286043)
4 years, 3 months ago (2016-08-27 02:15:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2286003002/1
4 years, 3 months ago (2016-08-28 01:05:19 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-28 02:43:23 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-08-28 02:45:40 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d1109b15f8669b2c342d87e9ae6e5d8ebd669ada
Cr-Commit-Position: refs/heads/master@{#414952}

Powered by Google App Engine
This is Rietveld 408576698